Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Replace guardrails with safeguards #7260

Merged
merged 14 commits into from
Feb 28, 2024

Conversation

NickKeller
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 6, 2024

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove aks create cmd aks create removed parameter guardrails_excluded_ns please add back parameter guardrails_excluded_ns for cmd aks create
1007 - ParaRemove aks create cmd aks create removed parameter guardrails_level please add back parameter guardrails_level for cmd aks create
1007 - ParaRemove aks create cmd aks create removed parameter guardrails_version please add back parameter guardrails_version for cmd aks create
1007 - ParaRemove aks update cmd aks update removed parameter guardrails_excluded_ns please add back parameter guardrails_excluded_ns for cmd aks update
1007 - ParaRemove aks update cmd aks update removed parameter guardrails_level please add back parameter guardrails_level for cmd aks update
1007 - ParaRemove aks update cmd aks update removed parameter guardrails_version please add back parameter guardrails_version for cmd aks update
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter safeguards_excluded_ns
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter safeguards_level
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter safeguards_version
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter safeguards_excluded_ns
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter safeguards_level
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter safeguards_version

Copy link

Hi @NickKeller,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 6, 2024

AKS

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm

src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved
src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_create_with_safeguards
  • test_aks_update_with_safeguards

@NickKeller
Copy link
Member Author

Queued live test to validate the change.

Live test passed, and merge conflicts are resovled

@qpetraroia
Copy link

@FumingZhang is this good to be merged?

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

+++++++
* Replace `guardrails` parameters with `safeguards`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change is a breaking change, it is better to specify "breaking change" in the history notes, so that users can be easily aware of that.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanzhudd, does it matter even if the feature was never released?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The major version was also increased too, users can see that

@qpetraroia
Copy link

If there are no problems, can this please be merged? We are aiming for a kubecon eu release.

@wangzelin007 wangzelin007 merged commit 6567c72 into Azure:main Feb 28, 2024
14 of 16 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=134557&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants