[dataprotection] Add support for Cross Region Restore for Backup Vaults #7282

zubairabid · 2024-02-12T01:56:53Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Added support for Cross Region Restore for Backup Vaults.
az dataprotection backup-vault create: New parameter --cross-region-restore-state/--crr-state that can be set to Enabled/Disabled.
az dataprotection backup-vault update: New parameter --cross-region-restore-state/--crr-state that can be set to Enabled/Disabled.
az dataprotection backup-vault list-from-resourcegraph: New command to fetch Backup Vault details from Azure Resource Graph.
az dataprotection recovery-point list: New parameter --use-secondary-region to be used when listing from the secondary region.
az dataprotection backup-instance validate-for-restore: New parameter --use-secondary-region to be used when restoring to the secondary region.
az dataprotection backup-instance restore trigger: New parameter --use-secondary-region to be used when restoring to the secondary region.
az dataprotection backup-job list: New parameter --use-secondary-region which can be used in disaster scenario when primary region is down.
az dataprotection backup-job show: New parameter --use-secondary-region which can be used in disaster scenario when primary region is down.

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

…anup BI init

Also code cleanup.

…on mapping as fallback in case of poorly populated fields from service.

azure-client-tools-bot-prd · 2024-02-12T01:56:56Z

❌Azure CLI Extensions Breaking Change Test

❌dataprotection

rule cmd_name rule_message suggest_message

❌ 1002 - CmdRemove dataprotection backup-instance update cmd dataprotection backup-instance update removed please confirm cmd dataprotection backup-instance update removed

⚠️ 1006 - ParaAdd dataprotection backup-instance list-from-resourcegraph cmd dataprotection backup-instance list-from-resourcegraph added parameter backup_instance_id

⚠️ 1006 - ParaAdd dataprotection backup-instance list-from-resourcegraph cmd dataprotection backup-instance list-from-resourcegraph added parameter backup_instance_name

⚠️ 1009 - ParaPropRemove dataprotection backup-instance list-from-resourcegraph cmd dataprotection backup-instance list-from-resourcegraph update parameter datasource_type: removed property required=True

⚠️ 1006 - ParaAdd dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger added parameter use_secondary_region

⚠️ 1009 - ParaPropRemove dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter backup_instance_name: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter backup_instance_name: removed property id_part=child_name_1

⚠️ 1009 - ParaPropRemove dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter no_wait: removed property aaz_type=bool

⚠️ 1009 - ParaPropRemove dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter no_wait: removed property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']

⚠️ 1009 - ParaPropRemove dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter no_wait: removed property nargs=?

⚠️ 1009 - ParaPropRemove dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter no_wait: removed property type=bool

⚠️ 1009 - ParaPropRemove dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter resource_group: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter resource_group: removed property type=string

⚠️ 1010 - ParaPropUpdate dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter resource_group: updated property name from resource_group to resource_group_name

⚠️ 1009 - ParaPropRemove dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter restore_request_object: removed property aaz_type=AAZFreeFormDictArg

⚠️ 1010 - ParaPropUpdate dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter restore_request_object: updated property type from Dict<String, Any> to custom_type

⚠️ 1009 - ParaPropRemove dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter vault_name: removed property aaz_type=string

⚠️ 1010 - ParaPropUpdate dataprotection backup-instance update-msi-permissions cmd dataprotection backup-instance update-msi-permissions update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']

⚠️ 1010 - ParaPropUpdate dataprotection backup-instance update-policy cmd dataprotection backup-instance update-policy update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']

⚠️ 1010 - ParaPropUpdate dataprotection backup-instance validate-for-backup cmd dataprotection backup-instance validate-for-backup update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']

⚠️ 1006 - ParaAdd dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore added parameter use_secondary_region

⚠️ 1009 - ParaPropRemove dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter backup_instance_name: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter backup_instance_name: removed property id_part=child_name_1

⚠️ 1009 - ParaPropRemove dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter no_wait: removed property aaz_type=bool

⚠️ 1009 - ParaPropRemove dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter no_wait: removed property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']

⚠️ 1009 - ParaPropRemove dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter no_wait: removed property nargs=?

⚠️ 1009 - ParaPropRemove dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter no_wait: removed property type=bool

⚠️ 1009 - ParaPropRemove dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter resource_group: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter resource_group: removed property type=string

⚠️ 1010 - ParaPropUpdate dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter resource_group: updated property name from resource_group to resource_group_name

⚠️ 1009 - ParaPropRemove dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter restore_request_object: removed property aaz_type=AAZFreeFormDictArg

⚠️ 1010 - ParaPropUpdate dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter restore_request_object: updated property type from Dict<String, Any> to custom_type

⚠️ 1009 - ParaPropRemove dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter vault_name: removed property aaz_type=string

⚠️ 1010 - ParaPropUpdate dataprotection backup-instance validate-for-restore cmd dataprotection backup-instance validate-for-restore update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']

⚠️ 1006 - ParaAdd dataprotection backup-vault create cmd dataprotection backup-vault create added parameter cross_region_restore_state

⚠️ 1001 - CmdAdd dataprotection backup-vault list-from-resourcegraph cmd dataprotection backup-vault list-from-resourcegraph added

⚠️ 1006 - ParaAdd dataprotection backup-vault update cmd dataprotection backup-vault update added parameter cross_region_restore_state

⚠️ 1006 - ParaAdd dataprotection job list cmd dataprotection job list added parameter use_secondary_region

⚠️ 1009 - ParaPropRemove dataprotection job list cmd dataprotection job list update parameter pagination_limit: removed property aaz_type=int

⚠️ 1010 - ParaPropUpdate dataprotection job list cmd dataprotection job list update parameter pagination_limit: updated property name from pagination_limit to max_items

⚠️ 1009 - ParaPropRemove dataprotection job list cmd dataprotection job list update parameter pagination_token: removed property aaz_type=string

⚠️ 1010 - ParaPropUpdate dataprotection job list cmd dataprotection job list update parameter pagination_token: updated property name from pagination_token to next_token

⚠️ 1009 - ParaPropRemove dataprotection job list cmd dataprotection job list update parameter resource_group: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection job list cmd dataprotection job list update parameter resource_group: removed property type=string

⚠️ 1010 - ParaPropUpdate dataprotection job list cmd dataprotection job list update parameter resource_group: updated property name from resource_group to resource_group_name

⚠️ 1009 - ParaPropRemove dataprotection job list cmd dataprotection job list update parameter vault_name: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection job list-from-resourcegraph cmd dataprotection job list-from-resourcegraph update parameter datasource_type: removed property required=True

⚠️ 1006 - ParaAdd dataprotection job show cmd dataprotection job show added parameter use_secondary_region

⚠️ 1009 - ParaPropRemove dataprotection job show cmd dataprotection job show update parameter job_id: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection job show cmd dataprotection job show update parameter resource_group: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection job show cmd dataprotection job show update parameter resource_group: removed property type=string

⚠️ 1010 - ParaPropUpdate dataprotection job show cmd dataprotection job show update parameter resource_group: updated property name from resource_group to resource_group_name

⚠️ 1009 - ParaPropRemove dataprotection job show cmd dataprotection job show update parameter vault_name: removed property aaz_type=string

⚠️ 1006 - ParaAdd dataprotection recovery-point list cmd dataprotection recovery-point list added parameter use_secondary_region

⚠️ 1009 - ParaPropRemove dataprotection recovery-point list cmd dataprotection recovery-point list update parameter backup_instance_name: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection recovery-point list cmd dataprotection recovery-point list update parameter end_time: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection recovery-point list cmd dataprotection recovery-point list update parameter pagination_limit: removed property aaz_type=int

⚠️ 1010 - ParaPropUpdate dataprotection recovery-point list cmd dataprotection recovery-point list update parameter pagination_limit: updated property name from pagination_limit to max_items

⚠️ 1009 - ParaPropRemove dataprotection recovery-point list cmd dataprotection recovery-point list update parameter pagination_token: removed property aaz_type=string

⚠️ 1010 - ParaPropUpdate dataprotection recovery-point list cmd dataprotection recovery-point list update parameter pagination_token: updated property name from pagination_token to next_token

⚠️ 1009 - ParaPropRemove dataprotection recovery-point list cmd dataprotection recovery-point list update parameter resource_group: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection recovery-point list cmd dataprotection recovery-point list update parameter resource_group: removed property type=string

⚠️ 1010 - ParaPropUpdate dataprotection recovery-point list cmd dataprotection recovery-point list update parameter resource_group: updated property name from resource_group to resource_group_name

⚠️ 1009 - ParaPropRemove dataprotection recovery-point list cmd dataprotection recovery-point list update parameter start_time: removed property aaz_type=string

⚠️ 1009 - ParaPropRemove dataprotection recovery-point list cmd dataprotection recovery-point list update parameter vault_name: removed property aaz_type=string

azure-client-tools-bot-prd · 2024-02-12T01:56:59Z

Hi @zubairabid,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-02-12T01:57:03Z

dataprotection

yonzhan · 2024-02-27T06:37:05Z

Please fix CI issues

zubairabid · 2024-02-28T03:48:07Z

Please fix CI issues

@yonzhan all CI issues have been fixed, could you please re-run the pipeline so the Cred scan passes this time?

zubairabid · 2024-03-12T05:28:47Z

@yonzhan @evelyn-ys can you please review and merge the PR?

evelyn-ys · 2024-03-12T05:34:09Z

src/dataprotection/setup.py

@@ -10,7 +10,7 @@
 from setuptools import setup, find_packages

 # HISTORY.rst entry.
-VERSION = '0.11.2'
+VERSION = '0.12.0'


Please check the version to follow https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md#versioning-practice

src/dataprotection/azext_dataprotection/manual/commands.py

evelyn-ys · 2024-03-12T05:50:43Z

There are some breaking changes which are not documented

Can you confirm it's necessary to make these breaking changes?

zubairabid · 2024-03-12T16:58:23Z

There are some breaking changes which are not documented Can you confirm it's necessary to make these breaking changes?

Removal of dataprotection backup-instance update is intentional. It had been incorrectly exposed due to misconfiguration in AAZ parameters. I am planning to re-add it with a better options in a PR later this month.

azclibot · 2024-03-13T02:23:02Z

[Release] Update index.json for extension [ dataprotection ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=138895&view=results

Zubair Abid added 16 commits January 12, 2024 13:00

Ignore intermediary jsons

f474fb5

Upgrade all modules to 2023-11-01

6e30148

Merge branch 'main' into users/zubair/dppcrr

535d0f0

all tests passing for updated API version

ff4097c

Add CRR group, validateCRR working, add ARG vault, modify ARG BI, cle…

1a1c25c

…anup BI init

fixed BI init, imports in helpers

38810fe

Restore trigger now definitely works, about to start customizing

aa6b47e

Validate CRR, BV list from resourcegraph complete

338191b

Also code cleanup.

Recovery point list supports use-secondary-region now

1d400ae

Complete commands: restore trigger, job fetch. Added a secondary regi…

823c02a

…on mapping as fallback in case of poorly populated fields from service.

Hiding explicit CRR commands

2da3af0

backup vault creation/editing with CRR

c56a4a2

Alias for --cross-region-restore-state

d709660

Backup vault ID option for list-from-resourcegraph

c040e7e

CRR Vault create, update tests updated

cf7c846

Backup vault list from RG test created

4ee05b3

azure-client-tools-bot-prd bot added this to the February 2024 (2024-03-05) milestone Feb 12, 2024

microsoft-github-policy-service bot requested review from yonzhan, evelyn-ys and calvinhzy February 12, 2024 01:57

microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Feb 12, 2024

microsoft-github-policy-service bot assigned evelyn-ys Feb 12, 2024

microsoft-github-policy-service bot added the Data Protection label Feb 12, 2024

Zubair Abid added 3 commits February 12, 2024 11:27

Cleaning up restore initialize

d78194f

Running tests

d8f0469

Complete all tests for CRR refresh

f232759

AllyW added the auto-cal-version label Feb 22, 2024

AllyW removed the auto-cal-version label Feb 23, 2024

Zubair Abid added 5 commits February 23, 2024 15:16

version number update

3cf7a4f

single job show added, all tests except CRR recorded

1db1a16

committing CRR test, runs but not recorded

20ca202

Everything complete, proceeding to review

e4a2237

Trying to pass the linter rules

896359a

zubairabid marked this pull request as ready for review February 27, 2024 05:36

Zubair Abid added 2 commits February 27, 2024 11:08

Updating history

d3f9fc2

linter show_job rules

166f1ce

Zubair Abid added 6 commits February 27, 2024 12:19

flake8 for test folder

a8d0e04

flake8 more issues

1ecc7b5

show_command for linter

6b633e8

fix show command

e88a7c1

All linters work

28ad23e

All linters work

f10c106

zubairabid mentioned this pull request Feb 29, 2024

[dataprotection] Add support for Cross Region Restore for Backup Vaults #7282 Azure/aaz#418

Merged

Help examples for CRR commands

706eee9

evelyn-ys reviewed Mar 12, 2024

View reviewed changes

src/dataprotection/azext_dataprotection/manual/commands.py Outdated Show resolved Hide resolved

Re-adding pagination parameters and no-wait for restore trigger

2c0372e

Zubair Abid added 2 commits March 12, 2024 22:30

Versioning with 1.0.0

ff70116

style fixes

bf71e51

evelyn-ys approved these changes Mar 13, 2024

View reviewed changes

evelyn-ys merged commit e95fbac into Azure:main Mar 13, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dataprotection] Add support for Cross Region Restore for Backup Vaults #7282

[dataprotection] Add support for Cross Region Restore for Backup Vaults #7282

zubairabid commented Feb 12, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Feb 12, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Feb 12, 2024

yonzhan commented Feb 12, 2024

yonzhan commented Feb 27, 2024

zubairabid commented Feb 28, 2024 •

edited

Loading

zubairabid commented Mar 12, 2024

evelyn-ys Mar 12, 2024

evelyn-ys commented Mar 12, 2024

zubairabid commented Mar 12, 2024

azclibot commented Mar 13, 2024

[dataprotection] Add support for Cross Region Restore for Backup Vaults #7282

[dataprotection] Add support for Cross Region Restore for Backup Vaults #7282

Conversation

zubairabid commented Feb 12, 2024 • edited Loading

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Feb 12, 2024 • edited Loading

azure-client-tools-bot-prd bot commented Feb 12, 2024

yonzhan commented Feb 12, 2024

yonzhan commented Feb 27, 2024

zubairabid commented Feb 28, 2024 • edited Loading

zubairabid commented Mar 12, 2024

evelyn-ys Mar 12, 2024

Choose a reason for hiding this comment

evelyn-ys commented Mar 12, 2024

zubairabid commented Mar 12, 2024

azclibot commented Mar 13, 2024

zubairabid commented Feb 12, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Feb 12, 2024 •

edited

Loading

zubairabid commented Feb 28, 2024 •

edited

Loading