Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{containerapp} remove additional conversion of binding name of Java component #7335

Merged
merged 19 commits into from
Mar 1, 2024

Conversation

ShichaoQiu
Copy link
Contributor

remove additional conversion of binding name of Java component

Copy link

azure-client-tools-bot-prd bot commented Mar 1, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @ShichaoQiu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @ShichaoQiu,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 1, 2024

Containerapp

@Greedygre
Copy link
Contributor

Please rerun tests relate to it, for example: test_containerapp_java_component

@Greedygre
Copy link
Contributor

This PR is for fix a logic which has not been released for customer in PR #7216, so no need to update history

@ShichaoQiu ShichaoQiu changed the title [Containerapp] remove additional conversion of binding name of Java component {containerapp} remove additional conversion of binding name of Java component Mar 1, 2024
Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test case for '-' scenario

@zhoxing-ms zhoxing-ms merged commit 310afb8 into Azure:main Mar 1, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants