Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liftr Confluent generated commands based out of stable version 13-02-2024 #7337

Merged

Conversation

DeepikaNMS
Copy link
Member

@DeepikaNMS DeepikaNMS commented Mar 1, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 1, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️confluent
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd confluent organization api-key sub group confluent organization api-key added
⚠️ 1001 - CmdAdd confluent organization create-role-binding cmd confluent organization create-role-binding added
⚠️ 1001 - CmdAdd confluent organization create-user cmd confluent organization create-user added
⚠️ 1011 - SubgroupAdd confluent organization environment sub group confluent organization environment added
⚠️ 1001 - CmdAdd confluent organization list-role-binding cmd confluent organization list-role-binding added
⚠️ 1001 - CmdAdd confluent organization list-service-accounts cmd confluent organization list-service-accounts added
⚠️ 1001 - CmdAdd confluent organization list-users cmd confluent organization list-users added
⚠️ 1011 - SubgroupAdd confluent organization role-binding sub group confluent organization role-binding added

Copy link

Hi @DeepikaNMS,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @DeepikaNMS,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 1, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@DeepikaNMS DeepikaNMS changed the title Liftr Confluent generated commands based out of stable version 123-02-2024 Liftr Confluent generated commands based out of stable version 13-02-2024 Mar 1, 2024
@DeepikaNMS
Copy link
Member Author

PR is based out of the swagger version - Azure/azure-rest-api-specs#27756

@jsntcy
Copy link
Member

jsntcy commented Mar 4, 2024

@DeepikaNMS, If you want to release the changes in this PR immediately in a new version, you need update the version and history notes as well.

updated the change log and history
@DeepikaNMS
Copy link
Member Author

@jsntcy: I have updated the history file and the version. Please review
There is a PR for aaz repo Azure/aaz#420

@necusjz
Copy link
Member

necusjz commented Mar 7, 2024

please update setup.py

@necusjz necusjz merged commit bb1faac into Azure:main Mar 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants