Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSH] Add SSHARC support to ARM64 architecture #7338

Merged
merged 11 commits into from
Mar 6, 2024

Conversation

vthiebaut10
Copy link
Contributor

@vthiebaut10 vthiebaut10 commented Mar 1, 2024

Fix: #6925 (comment)

  • Add support to ARM64 proxy
  • Download license files as part of the proxy package
  • Style fixes on test files

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 1, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @vthiebaut10,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @vthiebaut10,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 1, 2024

SSH

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Mar 4, 2024

@vthiebaut10 Could you please take a look at this comment? #7338 (comment)

src/ssh/HISTORY.md Outdated Show resolved Hide resolved
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
@zhoxing-ms zhoxing-ms merged commit f0f169c into Azure:main Mar 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

az ssh: unable to connect from client with ARM processor
3 participants