Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} az aks mesh get-upgrades fails with a traceback if ASM addon is disabled #7353

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Conversation

deveshdama
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks mesh get-upgrades -g my-rg --name my-aks

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 5, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 5, 2024

AKS

@SanyaKochhar
Copy link
Contributor

Could you include a screenshot of what the output will look like for a nil response? as in, will it warn? or give a [] or a nil?

@deveshdama
Copy link
Contributor Author

Could you include a screenshot of what the output will look like for a nil response? as in, will it warn? or give a [] or a nil?

Screenshot from 2024-03-05 15-02-57

@biefy
Copy link
Contributor

biefy commented Mar 5, 2024

'itertools.chain' object has no attribute 'by_page'

@deveshdama
Copy link
Contributor Author

'itertools.chain' object has no attribute 'by_page'

addressed.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_azure_service_mesh_get_upgrades

src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/custom.py Show resolved Hide resolved
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanzhudd yanzhudd merged commit f1ea4ca into Azure:main Mar 7, 2024
14 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Mar 7, 2024

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=137422&view=results

@FumingZhang
Copy link
Member

Fixed #7346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants