Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Version of Workloads Extension #7380

Merged
merged 20 commits into from
Mar 14, 2024
Merged

New Version of Workloads Extension #7380

merged 20 commits into from
Mar 14, 2024

Conversation

jaskisin
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

This contains the changes related to new version for Workloads extension. This has all the commands starting with 'az workloads'

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@jaskisin jaskisin requested a review from jsntcy as a code owner March 13, 2024 09:56
Copy link

Hi @jaskisin,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

azure-client-tools-bot-prd bot commented Mar 13, 2024

❌Azure CLI Extensions Breaking Change Test
❌workloads
rule cmd_name rule_message suggest_message
1007 - ParaRemove workloads sap-central-instance stop cmd workloads sap-central-instance stop removed parameter soft_stop_timeout_seconds please add back parameter soft_stop_timeout_seconds for cmd workloads sap-central-instance stop
1008 - ParaPropAdd workloads sap-virtual-instance list cmd workloads sap-virtual-instance list update parameter resource_group: added property required=True please remove property required=True for parameter resource_group of cmd workloads sap-virtual-instance list
⚠️ 1006 - ParaAdd workloads monitor list cmd workloads monitor list added parameter pagination_limit
⚠️ 1006 - ParaAdd workloads monitor list cmd workloads monitor list added parameter pagination_token
⚠️ 1006 - ParaAdd workloads monitor provider-instance list cmd workloads monitor provider-instance list added parameter pagination_limit
⚠️ 1006 - ParaAdd workloads monitor provider-instance list cmd workloads monitor provider-instance list added parameter pagination_token
⚠️ 1006 - ParaAdd workloads monitor sap-landscape-monitor list cmd workloads monitor sap-landscape-monitor list added parameter pagination_limit
⚠️ 1006 - ParaAdd workloads monitor sap-landscape-monitor list cmd workloads monitor sap-landscape-monitor list added parameter pagination_token
⚠️ 1006 - ParaAdd workloads sap-application-server-instance list cmd workloads sap-application-server-instance list added parameter pagination_limit
⚠️ 1006 - ParaAdd workloads sap-application-server-instance list cmd workloads sap-application-server-instance list added parameter pagination_token
⚠️ 1006 - ParaAdd workloads sap-application-server-instance start cmd workloads sap-application-server-instance start added parameter start_vm
⚠️ 1006 - ParaAdd workloads sap-application-server-instance stop cmd workloads sap-application-server-instance stop added parameter deallocate_vm
⚠️ 1001 - CmdAdd workloads sap-availability-zone-detail cmd workloads sap-availability-zone-detail added
⚠️ 1006 - ParaAdd workloads sap-central-instance list cmd workloads sap-central-instance list added parameter pagination_limit
⚠️ 1006 - ParaAdd workloads sap-central-instance list cmd workloads sap-central-instance list added parameter pagination_token
⚠️ 1006 - ParaAdd workloads sap-central-instance start cmd workloads sap-central-instance start added parameter start_vm
⚠️ 1006 - ParaAdd workloads sap-central-instance stop cmd workloads sap-central-instance stop added parameter deallocate_vm
⚠️ 1006 - ParaAdd workloads sap-database-instance list cmd workloads sap-database-instance list added parameter pagination_limit
⚠️ 1006 - ParaAdd workloads sap-database-instance list cmd workloads sap-database-instance list added parameter pagination_token
⚠️ 1006 - ParaAdd workloads sap-database-instance start cmd workloads sap-database-instance start added parameter start_vm
⚠️ 1006 - ParaAdd workloads sap-database-instance stop cmd workloads sap-database-instance stop added parameter deallocate_vm
⚠️ 1006 - ParaAdd workloads sap-virtual-instance create cmd workloads sap-virtual-instance create added parameter managed_resources_network_access_type
⚠️ 1006 - ParaAdd workloads sap-virtual-instance create cmd workloads sap-virtual-instance create added parameter mrgstracc
⚠️ 1006 - ParaAdd workloads sap-virtual-instance list cmd workloads sap-virtual-instance list added parameter pagination_limit
⚠️ 1006 - ParaAdd workloads sap-virtual-instance list cmd workloads sap-virtual-instance list added parameter pagination_token
⚠️ 1006 - ParaAdd workloads sap-virtual-instance start cmd workloads sap-virtual-instance start added parameter start_vm
⚠️ 1006 - ParaAdd workloads sap-virtual-instance stop cmd workloads sap-virtual-instance stop added parameter deallocate_vm
⚠️ 1006 - ParaAdd workloads sap-virtual-instance update cmd workloads sap-virtual-instance update added parameter configuration
⚠️ 1006 - ParaAdd workloads sap-virtual-instance update cmd workloads sap-virtual-instance update added parameter generic_update_add
⚠️ 1006 - ParaAdd workloads sap-virtual-instance update cmd workloads sap-virtual-instance update added parameter generic_update_force_string
⚠️ 1006 - ParaAdd workloads sap-virtual-instance update cmd workloads sap-virtual-instance update added parameter generic_update_remove
⚠️ 1006 - ParaAdd workloads sap-virtual-instance update cmd workloads sap-virtual-instance update added parameter generic_update_set
⚠️ 1006 - ParaAdd workloads sap-virtual-instance update cmd workloads sap-virtual-instance update added parameter managed_resource_group_configuration
⚠️ 1006 - ParaAdd workloads sap-virtual-instance update cmd workloads sap-virtual-instance update added parameter managed_resources_network_access_type
⚠️ 1006 - ParaAdd workloads sap-virtual-instance update cmd workloads sap-virtual-instance update added parameter no_wait

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 13, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@necusjz
Copy link
Member

necusjz commented Mar 14, 2024

please fix the ci

@necusjz necusjz merged commit 6a81c36 into Azure:main Mar 14, 2024
15 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ workloads ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=139408&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants