Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-08-01-preview nsp changes #7626

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhupeshbhatt1985
Copy link


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented May 16, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️nsp
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd network perimeter association reconcile cmd network perimeter association reconcile added
⚠️ 1006 - ParaAdd network perimeter profile access-rule create cmd network perimeter profile access-rule create added parameter service_tags
⚠️ 1001 - CmdAdd network perimeter profile access-rule reconcile cmd network perimeter profile access-rule reconcile added
⚠️ 1006 - ParaAdd network perimeter profile access-rule update cmd network perimeter profile access-rule update added parameter service_tags
⚠️ 1001 - CmdAdd network perimeter profile update cmd network perimeter profile update added
⚠️ 1001 - CmdAdd network perimeter update cmd network perimeter update added

Copy link

Hi @bhupeshbhatt1985,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @bhupeshbhatt1985,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented May 16, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

⚠️ Release Suggestions

Module: nsp

  • ⚠️ Please log updates into to src/nsp/HISTORY.rst
  • Update VERSION to 1.0.0b1 in src/nsp/setup.py
  • Set azext.isPreview to true in azext_metadata.json for nsp
  • Remove azext.isExperimental: true in azext_nsp/azext_metadata.json

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@wangzelin007 wangzelin007 added release-version-block Updates do not qualify release version rules and removed release-version-block Updates do not qualify release version rules labels May 17, 2024
@bhupeshbhatt1985 bhupeshbhatt1985 marked this pull request as draft May 17, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants