Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA version for command group acat #7723

Merged
merged 19 commits into from
Jul 12, 2024
Merged

Conversation

yanshudan
Copy link
Contributor

@yanshudan yanshudan commented Jun 18, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @yanshudan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 18, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jun 18, 2024

For more info about extension versioning, please refer to Extension version schema

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@kairu-ms kairu-ms self-assigned this Jul 1, 2024
src/acat/README.md Outdated Show resolved Hide resolved
@kairu-ms kairu-ms requested a review from necusjz July 1, 2024 05:11
@kairu-ms kairu-ms assigned necusjz and unassigned jsntcy Jul 1, 2024
@yanshudan yanshudan force-pushed the huiquan-pr branch 5 times, most recently from caad87f to 94ff11c Compare July 5, 2024 07:57
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules label Jul 8, 2024
@github-actions github-actions bot added release-version-block Updates do not qualify release version rules and removed release-version-block Updates do not qualify release version rules labels Jul 8, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules label Jul 8, 2024
@yanshudan yanshudan requested a review from kairu-ms July 10, 2024 04:31
Comment on lines 270 to 271
enum={"failed": "Failed", "succeeded": "Passed", "na": "Not Applicable"},
default="all",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "all" should be added as the enum option, otherwise the command will raise error. You can have a check by run the command without --compliance-status locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot repro this on my side. May I know the error message on your side? For the scenario in this command, sometimes we don't have snapshot available to show. So, the Snapshot not found error is by design.

But I will also add All as an enum in L270. Thanks

Comment on lines 523 to 525
wKey = str(args.webhook_key)
hasValidWebhookKey = wKey != "Undefined" and len(wKey) > 0
args.update_webhook_key = "true" if hasValidWebhookKey else "false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. And when the user set webhook_key as null, the service support to remove the key right? If that's true, then update_webhook_key should be true right?

Suggested change
wKey = str(args.webhook_key)
hasValidWebhookKey = wKey != "Undefined" and len(wKey) > 0
args.update_webhook_key = "true" if hasValidWebhookKey else "false"
If has_value(args.webhook_key):
args.update_webhook_key = "true"
else:
args.update_webhook_key = "false"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When user set webhook_key as null, we will not remove the key or update the key. The key will keep as it was. But your suggested change does reflect this logic. Updated as suggested.

@yanshudan yanshudan requested a review from kairu-ms July 10, 2024 08:56
@kairu-ms kairu-ms merged commit 9c8ff60 into Azure:main Jul 12, 2024
21 of 22 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ acat ] : https://dev.azure.com/azclitools/release/_build/results?buildId=171892&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants