-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA version for command group acat #7723
Conversation
Validation for Breaking Change Starting...
Thanks for your contribution! |
Hi @yanshudan, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
For more info about extension versioning, please refer to Extension version schema |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
src/acat/azext_acat/aaz/latest/app_compliance_automation/__cmd_group.py
Outdated
Show resolved
Hide resolved
src/acat/azext_acat/aaz/latest/app_compliance_automation/polling.py
Outdated
Show resolved
Hide resolved
caad87f
to
94ff11c
Compare
src/acat/azext_acat/custom.py
Outdated
enum={"failed": "Failed", "succeeded": "Passed", "na": "Not Applicable"}, | ||
default="all", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "all" should be added as the enum option, otherwise the command will raise error. You can have a check by run the command without --compliance-status locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot repro this on my side. May I know the error message on your side? For the scenario in this command, sometimes we don't have snapshot available to show. So, the Snapshot not found
error is by design.
But I will also add All
as an enum in L270. Thanks
src/acat/azext_acat/custom.py
Outdated
wKey = str(args.webhook_key) | ||
hasValidWebhookKey = wKey != "Undefined" and len(wKey) > 0 | ||
args.update_webhook_key = "true" if hasValidWebhookKey else "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. And when the user set webhook_key
as null, the service support to remove the key right? If that's true, then update_webhook_key
should be true right?
wKey = str(args.webhook_key) | |
hasValidWebhookKey = wKey != "Undefined" and len(wKey) > 0 | |
args.update_webhook_key = "true" if hasValidWebhookKey else "false" | |
If has_value(args.webhook_key): | |
args.update_webhook_key = "true" | |
else: | |
args.update_webhook_key = "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When user set webhook_key
as null, we will not remove the key or update the key. The key will keep as it was. But your suggested change does reflect this logic. Updated as suggested.
[Release] Update index.json for extension [ acat ] : https://dev.azure.com/azclitools/release/_build/results?buildId=171892&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.