Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] Use robot to update requirements.txt #28084

Open
bebound opened this issue Dec 22, 2023 · 2 comments
Open

[feature-request] Use robot to update requirements.txt #28084

bebound opened this issue Dec 22, 2023 · 2 comments
Assignees
Labels
Core CLI core infrastructure feature-request
Milestone

Comments

@bebound
Copy link
Contributor

bebound commented Dec 22, 2023

requirements.txt is introduced in #9785. It should be the result of pip freeze.
However, as time goes by, these files are edit manually when we bump package. Some dependencies are out-of-date and may have version conflict (see #28017).

I think we use a robot to improve this:

  1. Developers only need to modify setup.py.
  2. The robot creates requirements.txt using pip freeze and commits it to the pull request.
  3. (The robot may also periodically update requirements.txt.)
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 22, 2023

Thank you for opening this issue, we will look into it.

@yonzhan yonzhan added the Core CLI core infrastructure label Dec 22, 2023
@yonzhan yonzhan added this to the Backlog milestone Dec 22, 2023
@bebound
Copy link
Contributor Author

bebound commented Jan 8, 2024

I tried to use dependabot to do this. But it does not meet the requirement.

  1. It does not follow the constraint in setup.py and tries to update all package into latest version.
    https://github.com/bebound/azure-cli-dependa/pulls
    image

  2. pip-compile mode is close to our need, but we must create a requirements.in to tell dependabot to follow this file. Because it does not support setup.py file for now. However, we need 3 different requirements.txt. And I don't know how to tell dependabot to follow the requirements.in file.

PS: We can copy the dependency in setup.py to requirements.in and use this command to generate requirements.txt: pip-compile requirements.in --output-file requirements.txt --upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core CLI core infrastructure feature-request
Projects
None yet
Development

No branches or pull requests

2 participants