Fixes bug with adding hostname to web app. #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
suggested changes
Feb 6, 2017
| @@ -173,28 +173,27 @@ def show_container_settings(resource_group_name, name, slot=None): | |||
| def _filter_for_container_settings(settings): | |||
| return {x: settings[x] for x in settings if x in CONTAINER_APPSETTING_NAMES} | |||
|
|
|||
| def add_hostname(resource_group_name, webapp, name, slot=None): | |||
| def add_hostname(resource_group_name, webappName, name, slot=None): | |||
There was a problem hiding this comment.
This should be Python casing (i.e. webapp_name).
| webapp = client.sites.get_site(resource_group_name, webapp) | ||
| binding = HostNameBinding(webapp.location, host_name_binding_name=name, site_name=webapp) | ||
| webapp = client.sites.get_site(resource_group_name, webappName) | ||
| binding = HostNameBinding(webapp.location, host_name_binding_name=name, site_name=webapp.name) |
There was a problem hiding this comment.
So the problem was the parameter was redefined (webapp as a string in the method signature redefined to webapp the object). You could also use 'webapp_name' here too.
There was a problem hiding this comment.
Good, good, will do. I know the other methods were unaffected, but I wanted to keep them consistent. I will update today.
tjprescott
approved these changes
Feb 6, 2017
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1984.