Add descriptions for cloud commands and params #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
suggested changes
Feb 9, 2017
| @@ -21,14 +21,40 @@ def get_custom_cloud_name_completion_list(prefix, action, parsed_args, **kwargs) | |||
| completer=get_cloud_name_completion_list) | |||
|
|
|||
| register_cli_argument('cloud show', 'cloud_name', | |||
| help='Name of the registered cloud. If not specified, we use the current active cloud.') | |||
| help='Name of the registered cloud. If not specified, we use the active cloud.') | |||
There was a problem hiding this comment.
Can we not simply have the default value get the active cloud name (like VM admin username)? Then we don't need this "If not specified..." text and it will be clear what the active cloud is.
There was a problem hiding this comment.
Good suggestion!
Implemented.
…ashed commit) Squashed commits: [82d3fe9] Add descriptions for cloud commands and params
derekbekoe
force-pushed
the
cloud-descs
branch
from
f64376f
to
7bba4f1
Compare
troydai
approved these changes
Feb 10, 2017
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| from azure.cli.core.commands import register_cli_argument | |||
|
|
|||
| from azure.cli.core.cloud import get_clouds, get_custom_clouds | |||
| from azure.cli.core.cloud import get_clouds, get_custom_clouds, get_active_cloud_name | |||
|
|
|||
|
|
|||
| # pylint: disable=line-too-long | |||
There was a problem hiding this comment.
if nothing is violate this rule, can we remove it?
There was a problem hiding this comment.
_params.py (and commands.py) are the main cases where we deliberately keep this in. We went back in forth on the single-line/multi-line thing and ultimately went the route of single line, which all but guarantees this Pylint check should be disabled.
tjprescott
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.