Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packaging] BREAKING CHANGE: Drop jmespath-terminal from docker image #21206

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Feb 7, 2022

Description

jmespath-terminal no longer installes with latest setuptools because it uses very old urwid==1.2.2 (jmespath/jmespath.terminal#19). This issue was reported in 2018 but per https://pypi.org/project/jmespath-terminal/, the latest version of jmespath-terminal was released on Oct 6, 2015.

This causes CI failure and blocks PR (#21057 (comment)):

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1341309&view=logs&j=a3141784-dfa9-5792-78cc-844daee2d774&t=b2b6de04-64e4-5812-4fff-06c02d19f4c2&l=214

    error in urwid setup command: use_2to3 is invalid.
    Couldn't build the extension module, trying without it...
    ----------------------------------------
WARNING: Discarding https://files.pythonhosted.org/packages/0c/6a/c6eceee1b52004d791b1249d798e3a6ef280a8ab5645b5e5246e8e73c7cb/urwid-1.2.2.tar.gz#sha256=e122e2dee122314f5626945af4dbe15bf3de9f318c552a4c0b68c1c480852d92 (from https://pypi.org/simple/urwid/). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
Collecting jmespath-terminal
  Downloading jmespath-terminal-0.2.0.tar.gz (6.2 kB)
Collecting Pygments<=2.0,>=1.6
  Downloading Pygments-2.0-py3-none-any.whl (672 kB)
Collecting jmespath-terminal
  Downloading jmespath-terminal-0.1.1.tar.gz (5.1 kB)
  Downloading jmespath-terminal-0.1.0.tar.gz (3.8 kB)
  Downloading jmespath-terminal-0.0.1.tar.gz (3.4 kB)
ERROR: Cannot install jmespath-terminal==0.0.1, jmespath-terminal==0.1.0, jmespath-terminal==0.1.1, jmespath-terminal==0.2.0 and jmespath-terminal==0.2.1 because these package versions have conflicting dependencies.

The conflict is caused by:
    jmespath-terminal 0.2.1 depends on urwid==1.2.2
    jmespath-terminal 0.2.0 depends on urwid==1.2.2
    jmespath-terminal 0.1.1 depends on urwid==1.2.2
    jmespath-terminal 0.1.0 depends on urwid==1.2.2
    jmespath-terminal 0.0.1 depends on urwid==1.2.2

Since jmespath-terminal seems to be no longer maintained, we should drop it.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 7, 2022

Packaging

@yonzhan yonzhan added this to the Feb 2022 (2022-03-01) milestone Feb 7, 2022
@jiasli jiasli changed the title [Packaging] Drop jmespath-terminal from docker image [Packaging] BREAKING CHANGE: Drop jmespath-terminal from docker image Feb 7, 2022
@jiasli jiasli merged commit 0451b1d into Azure:dev Feb 7, 2022
@jiasli jiasli deleted the jmespath-terminal branch February 7, 2022 03:41
zhoxing-ms pushed a commit to zhoxing-ms/azure-cli that referenced this pull request Feb 14, 2022
zhoxing-ms added a commit that referenced this pull request Feb 14, 2022
* [Packaging] BREAKING CHANGE: Drop `jmespath-terminal` from docker image (#21206)

* {Packaging} Fix CI job "Test Yum Package" by using `centos7` (#21207)

* Update azure-pipelines.yml for Azure Pipelines (#21230)

Pin version for cred scan

Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants