-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{packaging} Update antlr4 to 4.9.3 #22469
Conversation
Thank you for your contribution major! We will review the pull request and get back to you soon. |
I'm curious to see if tests pass with this change. My quick tests seemed to work okay, but the CI here is much more thorough. 😉 |
Update the antlr4-python3-runtime requirement to 4.9.3. That's the most modern version available without moving to the 4.10.x releases (which have larger changes). The 4.7.2 version was released in 2018 and makes it difficult to package/test azure-cli in Fedora releases. Signed-off-by: Major Hayden <major@mhtx.net>
|
For what it's worth, the antlr4 version in the latest Debian/Ubuntu release is The Fedora Linux maintainer said that going from 4.9 to 4.10 involves some breaking changes, but it depends on what functions of antlr4 that are used by the Python code in question. 🤷🏻♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Related command
az monitor
Description
The current dependency of
antlr4-python3-runtime
is from 2018, but many distributions, including Fedora, are packaging the 4.9.x branch.Testing Guide
The same tests should be run using the same methods.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.