{packaging} Update antlr4 to 4.9.3 #22469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
customer-reported
|
Thank you for your contribution major! We will review the pull request and get back to you soon. |
ghost
requested review from
|
I'm curious to see if tests pass with this change. My quick tests seemed to work okay, but the CI here is much more thorough. 😉 |
Update the antlr4-python3-runtime requirement to 4.9.3. That's the most modern version available without moving to the 4.10.x releases (which have larger changes). The 4.7.2 version was released in 2018 and makes it difficult to package/test azure-cli in Fedora releases. Signed-off-by: Major Hayden <major@mhtx.net>
|
|
|
For what it's worth, the antlr4 version in the latest Debian/Ubuntu release is The Fedora Linux maintainer said that going from 4.9 to 4.10 involves some breaking changes, but it depends on what functions of antlr4 that are used by the Python code in question. 🤷🏻♂️ |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az monitorDescription
The current dependency of
antlr4-python3-runtimeis from 2018, but many distributions, including Fedora, are packaging the 4.9.x branch.Testing Guide
The same tests should be run using the same methods.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.