Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentDB: Adding support for listing connection strings #2580

Merged
merged 27 commits into from Mar 28, 2017

Conversation

dmakwana
Copy link
Contributor

This is useful for MongoDB based DocumentDB accounts. Now referencing azure-mgmt-documentdb==0.1.1. Upgraded from azure-mgmt-documentdb==0.1.0

@msftclas
Copy link

@dmakwana,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@lostintangent
Copy link
Member

Awesome! Would it be possible for the output of the az documentdb create command to display the MongoDB connection string after completion (if --kind MongoDB was set)? This way the user doesn't need to immediately re-run list-connection-strings to retrieve it, and it circumvents them from potentially getting confused with the connection string that is displayed by default.

@dmakwana
Copy link
Contributor Author

@lostintangent This is required also from REST/PowerShell; users need to call the list-connection-string operation manually. For parity, we will leave it like this for the time being

@derekbekoe
Copy link
Member

@dmakwana please rebase and resolve conflicts

@troydai
Copy link
Contributor

troydai commented Mar 23, 2017

@dmakwana please fix CI failures.

@dmakwana
Copy link
Contributor Author

@troydai Is there any way to kick this off again? The failure doesn't seem related to my changes. It's a storage account test and it's only failing for python 3.5

@troydai
Copy link
Contributor

troydai commented Mar 27, 2017

@dmakwana I reset the tests.

@dmakwana
Copy link
Contributor Author

@troydai Seems like the Travis CI server isn't co-operating. It failed but it won't populate the job log. Any idea?

@codecov-io
Copy link

Codecov Report

Merging #2580 into master will increase coverage by 0.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2580      +/-   ##
==========================================
+ Coverage   72.58%   73.31%   +0.73%     
==========================================
  Files         374      397      +23     
  Lines       20297    22798    +2501     
  Branches     2971     3593     +622     
==========================================
+ Hits        14732    16715    +1983     
- Misses       4638     5071     +433     
- Partials      927     1012      +85
Impacted Files Coverage Δ
...tdb/azure/cli/command_modules/documentdb/custom.py 10.63% <ø> (ø) ⬆️
...b/azure/cli/command_modules/documentdb/commands.py 93.75% <100%> (+0.41%) ⬆️
...or/azure/cli/command_modules/monitor/validators.py 15.78% <0%> (-34.22%) ⬇️
.../azure/cli/command_modules/vm/_template_builder.py 78.66% <0%> (-2.29%) ⬇️
...li-batch/azure/cli/command_modules/batch/custom.py 82.06% <0%> (-0.72%) ⬇️
src/azure-cli-testsdk/azure/cli/testsdk/patches.py 82.85% <0%> (-0.48%) ⬇️
...ure-cli-sql/azure/cli/command_modules/sql/_util.py 90.19% <0%> (-0.03%) ⬇️
...mmand_modules/azure-cli-role/azure/cli/__init__.py 100% <0%> (ø) ⬆️
...vice/azure/cli/command_modules/appservice/_help.py 100% <0%> (ø) ⬆️
...onitor/azure/cli/command_modules/monitor/params.py 100% <0%> (ø) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8780a...8602384. Read the comment docs.

@troydai
Copy link
Contributor

troydai commented Mar 28, 2017

@dmakwana tests were reset and passed. There was an operational issue with Travis CI. In multiple cases I observed the missing logging issue.

Copy link
Contributor

@troydai troydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I'll merge this shortly.

@troydai troydai merged commit 8bac701 into Azure:master Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants