New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocumentDB: Adding support for listing connection strings #2580
Conversation
@dmakwana, |
Awesome! Would it be possible for the output of the |
@lostintangent This is required also from REST/PowerShell; users need to call the list-connection-string operation manually. For parity, we will leave it like this for the time being |
@dmakwana please rebase and resolve conflicts |
@dmakwana please fix CI failures. |
@troydai Is there any way to kick this off again? The failure doesn't seem related to my changes. It's a storage account test and it's only failing for python 3.5 |
@dmakwana I reset the tests. |
@troydai Seems like the Travis CI server isn't co-operating. It failed but it won't populate the job log. Any idea? |
Codecov Report
@@ Coverage Diff @@
## master #2580 +/- ##
==========================================
+ Coverage 72.58% 73.31% +0.73%
==========================================
Files 374 397 +23
Lines 20297 22798 +2501
Branches 2971 3593 +622
==========================================
+ Hits 14732 16715 +1983
- Misses 4638 5071 +433
- Partials 927 1012 +85
Continue to review full report at Codecov.
|
@dmakwana tests were reset and passed. There was an operational issue with Travis CI. In multiple cases I observed the missing logging issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I'll merge this shortly.
This is useful for MongoDB based DocumentDB accounts. Now referencing azure-mgmt-documentdb==0.1.1. Upgraded from azure-mgmt-documentdb==0.1.0