Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appservice: support binding wildcard certificates #2625

Merged
merged 4 commits into from Mar 27, 2017

Conversation

yugangw-msft
Copy link
Contributor

fix #2561
(per standard, wildcard only covers one level of subdomains)

@codecov-io
Copy link

codecov-io commented Mar 24, 2017

Codecov Report

Merging #2625 into master will increase coverage by 0.03%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2625      +/-   ##
==========================================
+ Coverage   71.95%   71.99%   +0.03%     
==========================================
  Files         375      375              
  Lines       20602    20612      +10     
  Branches     3012     3017       +5     
==========================================
+ Hits        14825    14839      +14     
- Misses       4846     4848       +2     
+ Partials      931      925       -6
Impacted Files Coverage Δ
...ice/azure/cli/command_modules/appservice/custom.py 74.11% <91.3%> (+1.18%) ⬆️
...-cli-role/azure/cli/command_modules/role/custom.py 17.89% <0%> (ø) ⬆️
...dback/azure/cli/command_modules/feedback/custom.py 34.69% <0%> (ø) ⬆️
src/azure-cli-core/azure/cli/core/_util.py 66.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d8a30...7ba3d84. Read the comment docs.

@troydai troydai merged commit 767772d into Azure:master Mar 27, 2017
@yugangw-msft yugangw-msft deleted the certcert branch March 30, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants