New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appservice: support to get external ip address used for DNS A records #2627
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2627 +/- ##
==========================================
+ Coverage 71.87% 71.89% +0.01%
==========================================
Files 377 377
Lines 20729 20745 +16
Branches 3048 3051 +3
==========================================
+ Hits 14900 14914 +14
- Misses 4890 4892 +2
Partials 939 939
Continue to review full report at Codecov.
|
Reopening. The PR was auto-closed when I rebased to the master and in the middle I removed my commit by mistake. |
@derekbekoe , @troydai comparing with what you reviewed, I rolled back the command arg renaming, as I like to do that breaking change through a separate PR |
fix #1836