Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appservice: support to get external ip address used for DNS A records #2627

Merged
merged 3 commits into from Mar 27, 2017

Conversation

yugangw-msft
Copy link
Contributor

fix #1836

@codecov-io
Copy link

codecov-io commented Mar 24, 2017

Codecov Report

Merging #2627 into master will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2627      +/-   ##
==========================================
+ Coverage   71.87%   71.89%   +0.01%     
==========================================
  Files         377      377              
  Lines       20729    20745      +16     
  Branches     3048     3051       +3     
==========================================
+ Hits        14900    14914      +14     
- Misses       4890     4892       +2     
  Partials      939      939
Impacted Files Coverage Δ
...vice/azure/cli/command_modules/appservice/_help.py 100% <100%> (ø) ⬆️
...e/azure/cli/command_modules/appservice/commands.py 89.7% <100%> (+0.15%) ⬆️
...ice/azure/cli/command_modules/appservice/custom.py 74.39% <85.71%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55705db...c3ee812. Read the comment docs.

@yugangw-msft
Copy link
Contributor Author

Reopening. The PR was auto-closed when I rebased to the master and in the middle I removed my commit by mistake.

@yugangw-msft
Copy link
Contributor Author

@derekbekoe , @troydai comparing with what you reviewed, I rolled back the command arg renaming, as I like to do that breaking change through a separate PR

@yugangw-msft yugangw-msft merged commit 62342bb into Azure:master Mar 27, 2017
@yugangw-msft yugangw-msft deleted the ipip branch March 27, 2017 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants