Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login: skip erroneous tenant #2634

Merged
merged 2 commits into from Mar 27, 2017
Merged

Conversation

yugangw-msft
Copy link
Contributor

Fix #2591.
The context is users might have tenant where his account is disabled by admin, failing the whole login flow is not the optimal experience as this blocks them from using subscription in legit tenants.

Copy link
Member

@derekbekoe derekbekoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Mar 27, 2017

Codecov Report

Merging #2634 into master will increase coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2634      +/-   ##
==========================================
+ Coverage   71.81%   72.23%   +0.42%     
==========================================
  Files         376      396      +20     
  Lines       20708    21397     +689     
  Branches     3038     3103      +65     
==========================================
+ Hits        14871    15457     +586     
- Misses       4903     4978      +75     
- Partials      934      962      +28
Impacted Files Coverage Δ
src/azure-cli-core/azure/cli/core/_profile.py 84.36% <100%> (+0.17%) ⬆️
...ure-cli-sql/azure/cli/command_modules/sql/_util.py 90% <0%> (ø) ⬆️
...-cli-sql/azure/cli/command_modules/sql/commands.py 100% <0%> (ø) ⬆️
...-cli-dls/azure/cli/command_modules/dls/__init__.py 100% <0%> (ø)
...re-cli-dla/azure/cli/command_modules/dla/custom.py 50.47% <0%> (ø)
...zure-cli-dls/azure/cli/command_modules/__init__.py 100% <0%> (ø)
...rc/command_modules/azure-cli-dls/azure/__init__.py 100% <0%> (ø)
...i-dls/azure/cli/command_modules/dls/_validators.py 31.57% <0%> (ø)
...-cli-dls/azure/cli/command_modules/dls/commands.py 100% <0%> (ø)
...-cli-dla/azure/cli/command_modules/dla/__init__.py 100% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afee409...f7c206b. Read the comment docs.

@yugangw-msft yugangw-msft merged commit 55705db into Azure:master Mar 27, 2017
@yugangw-msft yugangw-msft deleted the skiptenant branch March 30, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants