[Network] az network dns zone import: Fix alias records cannot be imported - #26507
Merged
Conversation
Nicolai Søborg (nis-spiir)
requested review from
Yu Chen (jsntcy),
kai ru (kairu-ms),
Ethan Yang (necusjz) and
ZelinWang (wangzelin007)
as code owners
May 22, 2023 15:58
️✔️AzureCLI-FullTest
|
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
ghost
added
the
customer-reported
|
Thank you for your contribution nis-spiir! We will review the pull request and get back to you soon. |
ghost
requested a review
from Yong Zhang (yonzhan)
May 22, 2023 15:59
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Ethan Yang (necusjz)
changed the title
alias recordsaz network dns zone import: Fix alias records cannot be imported
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
Looks like the pipeline fails due to some unrelated |
Ethan Yang (necusjz)
approved these changes
May 24, 2023
vidit-msft
pushed a commit
to vidit-msft/azure-cli
that referenced
this pull request
Jun 27, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network dns zone import --name … --resource-group … --subscription … --file-name …Description
I'm importing a very small zone, but it fails due to the APEX being an (Azure)Alias record? The zone is generated using
zone exportcommand and all records are generated by Azure Portal.Relevant traceback:
The code is very convoluted, so I think this is a tiny patch, but the proper solution is to rewrite some of it (tests would also help!)
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking changeThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.