[App Service] Fix #21168: az webapp deploy: Call OneDeploy through ARM proxy if --src-url is provided
#26620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
ghost
added
the
ghost
requested review from
|
App Service |
zhoxing-ms
reviewed
Jun 8, 2023
zhoxing-ms
reviewed
Jun 8, 2023
zhoxing-ms
reviewed
Jun 8, 2023
src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_webapp_commands.py
Outdated
Show resolved
Hide resolved
dannysongg
changed the title
--src-url is providedaz webapp deploy: Call OneDeploy through ARM proxy if --src-url is provided
zhoxing-ms
reviewed
Jun 9, 2023
zhoxing-ms
reviewed
Jun 9, 2023
zhoxing-ms
reviewed
Jun 15, 2023
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
|
@zhoxing-ms can you please review when you have some time? |
zhoxing-ms
approved these changes
Jun 20, 2023
zhoxing-ms
reviewed
Jun 21, 2023
Comment on lines
-2587
to
2591
| @live_only() | ||
| @ResourceGroupPreparer(name_prefix='cli_test_webapp_OneDeploy', location=WINDOWS_ASP_LOCATION_WEBAPP) | ||
| def test_one_deploy(self, resource_group): | ||
| def test_one_deploy_scm(self, resource_group): | ||
| webapp_name = self.create_random_name('webapp-oneDeploy-test', 40) | ||
| plan_name = self.create_random_name('webapp-oneDeploy-plan', 40) | ||
| war_file = os.path.join(TEST_DIR, 'sample.war') |
There was a problem hiding this comment.
@dannysongg Since the @live_only() label of this test has been removed, our CI pipeline currently perform it's recording test.
war_file = os.path.join(TEST_DIR, 'sample.war')
Please move the sample.war file to the src/azure-cli/azure/cli/command_modules/appservice/tests/latest/data folder, otherwise it will cause the execution of package tests in our Batch CI pipeline to fail. pipeline link
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…ough ARM proxy if `--src-url` is provided (Azure#26620)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp deploy
Description
Enable the az webap deploy command to perform a pull based deployment from a remote URL through the OneDeploy API using the ARM proxy if
-src-urlis provided. This is to allow us to deploy to isolated environments such as ILB ASE which cannot be deployed to through the traditional pushed based SCM deployment.Testing Guide
azdev test WebappOneDeployScenarioTest --live(This will run the test for both the SCM and ARM scenarios to ensure backwards compatibility)This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.