-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevTestLabs] Exposing commands to manage secrets in the lab #2691
Changes from 8 commits
f3166e4
0627b05
ccd8e8a
d9b0469
4ef36cd
e513451
b630586
6499776
7758106
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,6 +80,10 @@ def validate_lab_vm_list(namespace): | |
namespace.filters = "Properties/ownerObjectId eq '{}'".format(object_id) | ||
|
||
|
||
def validate_user_name(namespace): | ||
namespace.user_name = "@me" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this for? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. REST endpoint exposes For that reason I've created validator to default. Let me know if that is not the way we should be defaulting. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this command is reflecting on the SDK, then this is perfectly acceptable. If it calls into a custom command, then you can just omit that parameter in the signature and plug in "@me" where appropriate. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup all the secret commands are now just reflecting on SDK |
||
|
||
|
||
# pylint: disable=no-member | ||
def _validate_location(namespace): | ||
""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are the release notes FOR DevTestLab (instead of the CLI in general), I would recommend something like: