{Keyvault} Fix test failure in az keyvault certificate create
#27016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
added
the
|
Keyvault |
ghost
requested a review
from 
jiasli
approved these changes
Jul 27, 2023
|
To troubleshoot multithreading issues, let The log shows both
azure-cli/src/azure-cli/azure/cli/command_modules/keyvault/custom.py Lines 1551 to 1552 in 7a22417 The The Conflict occurs because the recording
|
jiasli
reviewed
Jul 27, 2023
| @@ -259,7 +257,7 @@ interactions: | |||
| uri: https://cli-test-kv-ct-sd-000002.vault.azure.net/certificates/cert1/pending?api-version=7.4 | |||
| response: | |||
| body: | |||
| string: '{"id":"https://cli-test-kv-ct-sd-000002.vault.azure.net/certificates/cert1/pending","issuer":{"name":"Self"},"csr":"MIIDFjCCAf4CAQAwdTEdMBsGA1UEAxMUd3d3Lm15dGVzdGRvbWFpbi5jb20xEzARBgNVBAsTClRlc3ROdWdnZXQxFDASBgNVBAoTC1Rlc3QgTm9vZGxlMQ8wDQYDVQQHEwZSZWRtb24xCzAJBgNVBAgTAldBMQswCQYDVQQGEwJVUzCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAOBjCOg4lKf1niwEhftBtaQH+YgxrqGy7HsiFW8TsDJNBXEC08qKtL0KFNyqVtJ2NPNOwQoq32cq8qZAorYt/PIPhxXo0DQU8K88roVOk042B26F2auitu5OqwgFniseQsYasCCrhLPOGSGdDG6TO2SXc0ANSCkg0de7w64htMfn1bNvG9AsfpZZ8dyoUg9nfpwOtu8VvWqd5T0hi3lbIr8rQJdeaZl+iuFwcp+QDt/OH7mo5eAjjxAJNeLo0I7tmULq3DBiiSq1QtEJAwhgyJW90QV9tFDIsNkfF2NRALhpD/TCJpUJwnqHTycanCRqetPWtTiWu+YLsv1oavBWKz0CAwEAAaBcMFoGCSqGSIb3DQEJDjFNMEswDgYDVR0PAQH/BAQDAgLsMB0GA1UdJQQWMBQGCCsGAQUFBwMBBggrBgEFBQcDAjAPBgNVHREECDAGggExggEyMAkGA1UdEwQCMAAwDQYJKoZIhvcNAQELBQADggEBAK3MV4U7gKiibw4hlmFIhaPYKAu4+vCEiS4tBKNr+77IxVgFH037bXC23fTgGWyCX7xrrgMU7yXrZKuTNz+hBu/5fi1mdlMDbFJfqjUCr3jqB+mYhdzZ96K/RvniJejC7lLpE7KTd3IuBndcbAJItvR4F8KogGN7zs/B1PQdm99TVcrApeZbA0LiZlg5/r0Eexf/LgsoAPu1qHWv/ryK6YAuI8ImJ3iwoRIudldoPQEQy1Y5p3MJZOthDpi149MLio3IM07vKywZX9viVvgDYb1xHpGuTOHAqIP9n8GzHtnCRSOg61xXQyv/bsn2V6ZiLolipVR98+38/sLgsIXMgnM=","cancellation_requested":false,"status":"completed","target":"https://cli-test-kv-ct-sd-000002.vault.azure.net/certificates/cert1","request_id":"e0775da185a5408bbd30f3bfe40d9b33"}' | |||
| string: '{"id":"https://cli-test-kv-ct-sd-000002.vault.azure.net/certificates/cert1/pending","issuer":{"name":"Self"},"csr":"MIIDFjCCAf4CAQAwdTEdMBsGA1UEAxMUd3d3Lm15dGVzdGRvbWFpbi5jb20xEzARBgNVBAsTClRlc3ROdWdnZXQxFDASBgNVBAoTC1Rlc3QgTm9vZGxlMQ8wDQYDVQQHEwZSZWRtb24xCzAJBgNVBAgTAldBMQswCQYDVQQGEwJVUzCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAK3jtchQr0nSlBSKlaKMN+ETENMd9QfvbE3rXOymj6VkLcYexkHdCUrB0C64xUTWZDb39iP9MDKRgHJU/lY5s701/CHP734YihoTbr6f+i1BqZydYYDA0oYA3dfVLhkEkHUYrJdPK/1i3KEqD57QpeB3zluEUNGST7GpsS0Qdd8Doq02gEejEisNqwSABNpar3A4RwxCIQ/TP+V2J5RCRS1ZwQgQgstaTCxqz7CcFfKOdu0/ecLszV3xpHIsvZp0I9qBn0yNxekES/IPnNDqXBsYnNV2yqJJKaTcFpURfleQvW8+SIrr/0aVKAgA2PDhvUWopHwSsl+LumrdfYE0k4kCAwEAAaBcMFoGCSqGSIb3DQEJDjFNMEswDgYDVR0PAQH/BAQDAgLsMB0GA1UdJQQWMBQGCCsGAQUFBwMBBggrBgEFBQcDAjAPBgNVHREECDAGggExggEyMAkGA1UdEwQCMAAwDQYJKoZIhvcNAQELBQADggEBAITTgptG9aJAjAKT5gj8nXnEIaBDq8o2KNrGnuNdJpF28kAYTyqRWsXYV8YqCSNu+wlQhGcu4JAnSC69155t0i5iKt9RuWFxioWEyZdlrOMwK+h6S7XIpucOGckhANb5mXEmVYXT897ICfb7q/10NthCRkMYeKcI+j64XgmEXVSONPUK77Z3NsXpLUN6HkZ1u7dog0HN3m6aNoVaCWUbBKVWMNxrZJm94h21JJGQK1ZyLD3AKYuwRHdDAFCUQlo+qN6kWBE/SsAHXbYF4PWQQmyIAZO4ZHmB/tE1LNypWtZQqn8Dtol6nez/zhWJDoUOYg9dPIBhIbyii4xHwssJcZo=","cancellation_requested":false,"status":"completed","target":"https://cli-test-kv-ct-sd-000002.vault.azure.net/certificates/cert1","request_id":"cc5cdd9c09324a6bbda8013c24394c95"}' | |||
There was a problem hiding this comment.
There are 2 responses with "status":"completed" now. This is one.
jiasli
reviewed
Jul 27, 2023
| uri: https://cli-test-kv-ct-sd-000002.vault.azure.net/certificates/cert1/pending?api-version=7.4 | ||
| response: | ||
| body: | ||
| string: '{"id":"https://cli-test-kv-ct-sd-000002.vault.azure.net/certificates/cert1/pending","issuer":{"name":"Self"},"csr":"MIIDFjCCAf4CAQAwdTEdMBsGA1UEAxMUd3d3Lm15dGVzdGRvbWFpbi5jb20xEzARBgNVBAsTClRlc3ROdWdnZXQxFDASBgNVBAoTC1Rlc3QgTm9vZGxlMQ8wDQYDVQQHEwZSZWRtb24xCzAJBgNVBAgTAldBMQswCQYDVQQGEwJVUzCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAK3jtchQr0nSlBSKlaKMN+ETENMd9QfvbE3rXOymj6VkLcYexkHdCUrB0C64xUTWZDb39iP9MDKRgHJU/lY5s701/CHP734YihoTbr6f+i1BqZydYYDA0oYA3dfVLhkEkHUYrJdPK/1i3KEqD57QpeB3zluEUNGST7GpsS0Qdd8Doq02gEejEisNqwSABNpar3A4RwxCIQ/TP+V2J5RCRS1ZwQgQgstaTCxqz7CcFfKOdu0/ecLszV3xpHIsvZp0I9qBn0yNxekES/IPnNDqXBsYnNV2yqJJKaTcFpURfleQvW8+SIrr/0aVKAgA2PDhvUWopHwSsl+LumrdfYE0k4kCAwEAAaBcMFoGCSqGSIb3DQEJDjFNMEswDgYDVR0PAQH/BAQDAgLsMB0GA1UdJQQWMBQGCCsGAQUFBwMBBggrBgEFBQcDAjAPBgNVHREECDAGggExggEyMAkGA1UdEwQCMAAwDQYJKoZIhvcNAQELBQADggEBAITTgptG9aJAjAKT5gj8nXnEIaBDq8o2KNrGnuNdJpF28kAYTyqRWsXYV8YqCSNu+wlQhGcu4JAnSC69155t0i5iKt9RuWFxioWEyZdlrOMwK+h6S7XIpucOGckhANb5mXEmVYXT897ICfb7q/10NthCRkMYeKcI+j64XgmEXVSONPUK77Z3NsXpLUN6HkZ1u7dog0HN3m6aNoVaCWUbBKVWMNxrZJm94h21JJGQK1ZyLD3AKYuwRHdDAFCUQlo+qN6kWBE/SsAHXbYF4PWQQmyIAZO4ZHmB/tE1LNypWtZQqn8Dtol6nez/zhWJDoUOYg9dPIBhIbyii4xHwssJcZo=","cancellation_requested":false,"status":"completed","target":"https://cli-test-kv-ct-sd-000002.vault.azure.net/certificates/cert1","request_id":"cc5cdd9c09324a6bbda8013c24394c95"}' |
There was a problem hiding this comment.
This is another one "status":"completed".
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…e#27016) * Fix certificate create * clean code * recover original logic * refine * fix linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az keyvault certificate createDescription
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.