{Packaging} Add setuptools into dependency
#27196
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
jiasli and
wangzelin007
|
Packaging |
bebound
force-pushed
the
add-setuptools
branch
from
9a9113d
to
8d6ea03
Compare
| @@ -122,7 +122,6 @@ set PYTHON_EXE=%PYTHON_DIR%\python.exe | |||
| robocopy %PYTHON_DIR% %BUILDING_DIR% /s /NFL /NDL | |||
|
|
|||
| set CLI_SRC=%REPO_ROOT%\src | |||
| %BUILDING_DIR%\python.exe -m pip install --no-warn-script-location --force-reinstall pycparser==2.18 | |||
There was a problem hiding this comment.
pycparser==2.18 does not work. It is in the requirements.txt and version is 2.19.
There was a problem hiding this comment.
pycparser==2.18 was added by #7662. Funny thing is that no one knows why it was introduced in the first place.
| @@ -129,6 +129,7 @@ requests-oauthlib==1.2.0 | |||
| requests[socks]==2.31.0 | |||
| scp==0.13.2 | |||
| semver==2.13.0 | |||
| setuptools | |||
There was a problem hiding this comment.
I think items under requirements.*.txt should always be pinned as requirements.txt is the output of pip freeze. This gives us a stable dependency tree when building packages.
There was a problem hiding this comment.
We do have a pinned version in requirements.*.txt
On the one hand, we always use latest setuptools and pip when build packages for now. We've used this strategy for years. #24992 (comment)
On the other hand, unpinned setuptools caused a problem before: #25869
|
What dependencies still use the deprecated |
Some packages are installed from source code on MacOS. Not sure if this problem still exists. |
|
How does getting installed from source relate to my question? |
|
This is only related to MacOS. Details are provided in the PR. |
|
In 2.61.0, these two files still exists in HomeBrew, which means They might be created by |
| @@ -144,6 +144,7 @@ | |||
| 'PyNaCl~=1.5.0', | |||
| 'scp~=0.13.2', | |||
| 'semver==2.13.0', | |||
| 'setuptools', | |||
There was a problem hiding this comment.
Once it's added in setup.py, brew will install setuptools while installing azure-cli.
The command is python3.xx -m pip --python=xxxxx/Cellar/azure-cli/2.xx.0/libexec/bin/python install buildpath/src/azure-cli.
Description
setuptoolswill not be installed when create venv in Python 3.12, see python/cpython#95299.But macOS dependencies are installed from source, some of them still use
__import__('pkg_resources').declare_namespace(__name__)to declare the namespace package, which requiressetuptools.Adding it into
setup.pyto make sure it is installed correctly when installazure-cliin Homebrew.setuptoolscan be removed if macOS dependencies do not usepkg_resourcesanymore.setuptoolsin all platforms:pipandsetuptoolsin build script.get-pip.pyto installsetuptoolsinexplicitly.get-pip.pyto installsetuptoolsinexplicitly.setuptoolswhen create venv, it will be removed in 3.12.Related issue:
--without-pipHomebrew/brew#15792Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.