[Sqlvm] Fix #27300: az sql vm group create: cluster_subnet_type should only be passed into WsfcDomainProfile
#27301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SqlVirtualMachineGroup
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
SQL |
microsoft-github-policy-service
bot
added
Auto-Assign
yonzhan
modified the milestones:
September 2023 (2023-09-26),
October 2023 (2023-11-15)❗ Breaking change release ❗
yonzhan
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
Backlog
…ate-cluster-subnet-type-warning # Conflicts: # src/azure-cli/azure/cli/command_modules/sqlvm/tests/latest/recordings/test_sqlvm_group_mgmt.yaml
calvinhzy
changed the title
az sql vm group create cluster_subnet_type should only be passed into WsfcDomainProfileaz sql vm group create: cluster_subnet_type should only be passed into WsfcDomainProfile
calvinhzy
changed the title
az sql vm group create: cluster_subnet_type should only be passed into WsfcDomainProfileaz sql vm group create: cluster_subnet_type should only be passed into WsfcDomainProfile
evelyn-ys
approved these changes
Feb 7, 2024
calvinhzy
changed the title
az sql vm group create: cluster_subnet_type should only be passed into WsfcDomainProfileaz sql vm group create: cluster_subnet_type should only be passed into WsfcDomainProfile
veppala
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Fix #27300
Stop passing
cluster_subnet_typetoSqlVirtualMachineGroupclass as the parameter is not in SDK or swaggerDescription
Testing Guide
History Notes
[Sqlvm] Fix #27300:
az sql vm group create:cluster_subnet_typeshould only be passed intoWsfcDomainProfileThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.