Improve performance of package load and command execution #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figuration. - Removed unused configuration object/argv on application create.
* Fix Azure#1615. * Code review feedback.
…ure#2763) * Update test docs for running individual test and all tests in mod * Made feedback changes
Make lock command parameter aliases match up with resource commands.
…M in lab (Azure#2767) * WIP create linux + Windows vm in lab * Adding recording
Add more validation to resolve "lock level" for lock commands.
* Core:apply configured defaults on optional argument * add a test * add tests * update history doc * address review feedback
* Fix doc references to azure.cli.commands This module has moved to azure.cli.core.commands * Fix PyLint
* Add clearer guidelines on modifying changelog * A few smaller changes * another small format change * Code review changes
…idation fail… (Azure#2764) * nulling out the windows profile so that there isn't a valdiation failure for missing password ACS doesn't return a password on GET. az acs scale command does a GET then PUT, but since ACS doesn't return the password the verification is failing before the PUT is sent to ACS. There is a bug in ACS this exposes. So this shouldn't be merged until after the ACS rollout finishes. Should be about start of next week. * updating history * updating version in history * removing white space added by editor
…#2773) * Fix issues with VMSS and VM availability set update. * Update help. Fix Azure#2762.
…s up raw az command)
Codecov Report
@@ Coverage Diff @@
## master #2819 +/- ##
==========================================
+ Coverage 62.89% 62.94% +0.04%
==========================================
Files 480 481 +1
Lines 26012 26074 +62
Branches 3946 3956 +10
==========================================
+ Hits 16361 16412 +51
- Misses 8627 8634 +7
- Partials 1024 1028 +4
Continue to review full report at Codecov.
|
xingwu1
approved these changes
Apr 10, 2017
tjprescott
approved these changes
Apr 10, 2017
| @@ -852,6 +854,45 @@ def _load_transformed_arguments(self, handler): | |||
| help=docstring)) | |||
|
|
|||
|
|
|||
| def validate_client_parameters(namespace): | |||
| """Retrieves Batch connection parameters from environment variables""" | |||
| from azure.mgmt.batch import BatchManagementClient | |||
There was a problem hiding this comment.
Is this just relocated or is it refactored? If so, might want @annatisch to review.
There was a problem hiding this comment.
It is just relocated. Adding @annatisch as a reviewer either way. Good call!
|
FYI @oakeyc this may impact you also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)
Delay load azure modules as much as possible to improve startup time.
az(without parameters) to be very slow, particularly on systems with less powerful CPUs.