Remove +dev from versions #4684
Conversation
derekbekoe
commented
Oct 16, 2017
derekbekoe
commented
- Remove +dev version nos.
- Remove 'unreleased' from release notes
- Fix scripts
- CI to verify the above
scripts/ci/test_integration.sh
Outdated
| ALL_MODULES="" | ||
| for f in $share_folder/build/* | ||
| do ALL_MODULES="$ALL_MODULES $f" | ||
| done |
There was a problem hiding this comment.
You can list all sub-directories in one command:
ls -d ./src/command_modules/*/
There was a problem hiding this comment.
I need all the filepaths, not the sub-directories.
i.e. azure-cli.whl core.whl storage.whl etc.
There was a problem hiding this comment.
then do
find $share_folder/build/ -name "*.whl"
scripts/ci/test_static.sh
Outdated
| ALL_MODULES="" | ||
| for f in $share_folder/build/* | ||
| do ALL_MODULES="$ALL_MODULES $f" | ||
| done |
scripts/ci/test_static.sh
Outdated
| pip install pylint flake8 | ||
| pip install azure-cli-fulltest -f $share_folder/build |
There was a problem hiding this comment.
Why can't we use azure-cli-fulltest anymore?
There was a problem hiding this comment.
$ALL_MODULES includes azure-cli-fulltest as well.
Background to this change though is pip install azure-cli-fulltest -f $share_folder/build, the -f may not install the .whl in the directory if there's a newer version available on PyPI.
I want to make sure we're running tests with the version in the directory. By specifying all the whl files, we ensure that we're installing the right packages.
There was a problem hiding this comment.
Ok. we should look into this. may be the azure-cli-fulltest should match the exact version.
scripts/ci/version.sh
Outdated
| else | ||
| sed -i "s/^VERSION = [\"']\(.*\)+dev[\"']/VERSION = \"\1+dev.$version\"/" $each | ||
| sed -i "s/^VERSION = [\"']\(.*\)[\"']/VERSION = \"\1.$version\"/" $each |
There was a problem hiding this comment.
This is used to generate edge build. With the +dev gone, we need to make sure the version scheme still works for edge build.
There was a problem hiding this comment.
Yes. Can you take a look at this since you know about this? Is there something I can do to verify?
There was a problem hiding this comment.
use .devN
For example.
The version in the source code is 2.0.19. The version of the latest PyPI package is 2.0.18
The nightly version become 2.0.19.dev4345. The digits follows dev is Travis build number.
After release, the latest package in PyPI is 2.0.19. In the meantime, source code version is upgraded to 2.0.20.
There was a problem hiding this comment.
src/azure-cli-testsdk/HISTORY.rst
Outdated
| @@ -3,3 +3,6 @@ | |||
| Release History | |||
| =============== | |||
|
|
|||
| 0.1.0+dev | |||
There was a problem hiding this comment.
This package should follow the same scheme.
|
@troydai Feedback addressed. Can you take another look? |
derekbekoe
force-pushed
the
no-plus-dev
branch
from
cb55ee9
to
2b53b90
Compare
scripts/ci/test_static.sh
Outdated
| for f in $share_folder/build/* | ||
| do ALL_MODULES="$ALL_MODULES $f" | ||
| done | ||
| ALL_MODULES=find $share_folder/build/ -name "*.whl" |
There was a problem hiding this comment.
ALL_MODULES=`find $share_folder/build/ -name "*.whl"`
- Remove +dev version nos. - Fix scripts
derekbekoe
force-pushed
the
no-plus-dev
branch
from
cd8b0ae
to
a60ad1e
Compare
