Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes#5538: list_locations supports 'Free' and 'shared' as valid parameters #5552

Merged
merged 4 commits into from
Feb 13, 2018

Conversation

panchagnula
Copy link
Contributor

@panchagnula panchagnula commented Feb 12, 2018

Fixes #5538


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@promptws
Copy link

View a preview at https://prompt.ws/r/Azure/azure-cli/5552
This is an experimental preview for @microsoft users.

@panchagnula panchagnula self-assigned this Feb 12, 2018
@@ -6,6 +6,7 @@ Release History
++++++
* webapp backup/restore: Fix issue where restore command fails because of a null reference
* appservice: support default app service plan through `az configure --defaults appserviceplan=my-asp`
* appservice: list-location: reports Free as an invalid SKU
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the new version section, the current version will be released tomorrow.
Also the text should reflect what is being fixed, e.g. fix the bug that reports Free as an invalid SKU

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yugangw-msft & @tjprescott , i will make the change move to new version & update history. However, there is no existing test for list-locations, since this returns a list of locations from the API, & that is not a static list - so can we just check the response is 200, specifically for Free SKU? Let me know. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can verify the response is the same as from F1

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to a new or existing test.

@@ -2,6 +2,10 @@

Release History
===============
0.1.27
++++++
* appservice: list-location: reports Free as an invalid SKU
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this change actually fixes the issue where it reports Free as invalid.
This note makes it seem like now it will report Free as invalid.

@yugangw-msft yugangw-msft merged commit 743bd78 into Azure:dev Feb 13, 2018
@panchagnula panchagnula deleted the sisirap-bugfixesWebapp branch February 13, 2018 22:59
LukaszStem pushed a commit to LukaszStem/azure-cli that referenced this pull request Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants