-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes#5538: list_locations supports 'Free' and 'shared' as valid parameters #5552
Conversation
View a preview at https://prompt.ws/r/Azure/azure-cli/5552 |
@@ -6,6 +6,7 @@ Release History | |||
++++++ | |||
* webapp backup/restore: Fix issue where restore command fails because of a null reference | |||
* appservice: support default app service plan through `az configure --defaults appserviceplan=my-asp` | |||
* appservice: list-location: reports Free as an invalid SKU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in the new version section, the current version will be released tomorrow.
Also the text should reflect what is being fixed, e.g. fix the bug that reports Free as an invalid SKU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yugangw-msft & @tjprescott , i will make the change move to new version & update history. However, there is no existing test for list-locations, since this returns a list of locations from the API, & that is not a static list - so can we just check the response is 200, specifically for Free SKU? Let me know. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can verify the response is the same as from F1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be added to a new or existing test.
@@ -2,6 +2,10 @@ | |||
|
|||
Release History | |||
=============== | |||
0.1.27 | |||
++++++ | |||
* appservice: list-location: reports Free as an invalid SKU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this change actually fixes the issue where it reports Free as invalid.
This note makes it seem like now it will report Free as invalid.
Fixes #5538
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)