General code cleanup for Interactive, resolve pylint, some fixes #5745
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5745 |
williexu
changed the title
| columns = right - left + 1 | ||
| lines = bottom - top + 1 | ||
| return lines, columns | ||
| windll.kernel32.GetConsoleScreenBufferInfo(h, csbi) |
There was a problem hiding this comment.
Why have you removed the if condition here?
| def __init__(self): | ||
| self.command_table = None | ||
| self.shell_ctx = None | ||
| command_table = None |
There was a problem hiding this comment.
Why is this a class variable rather than an instance variable like it was before?
There was a problem hiding this comment.
We were using a global variable to keep an instance of the table as a singleton.
Keeping the table in a class as a variable accomplishes the same and seems to be preferable in python.
There was a problem hiding this comment.
It's hard to tell what's changed and what's just moved. As you yourself have pointed out, the interactive tests aren't great at preventing regressions, so hopefully you have thoroughly tested interactive manually with your changes. If not, you might defer this to the next release, especially if its mostly refactoring. But if you are happy with it, so am I.
-moved azclishell code to command_module/interactive folder
-command_table loading more robust to exceptions
Fixes: #5688
-fixed broken
--progressparam for long running operations-lots of code cleanup
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
(see Authoring Command Modules)