Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] Update help for nic ip-config create/update --private-ip-address #7459

Merged
merged 1 commit into from
Oct 1, 2018
Merged

[Network] Update help for nic ip-config create/update --private-ip-address #7459

merged 1 commit into from
Oct 1, 2018

Conversation

tjprescott
Copy link
Member

Makes clear how to use --private-ip-address to select Dynamic or Static behavior.

Closes #7176.


This checklist is used to make sure that common guidelines for a pull request are followed.

  • [N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@tjprescott tjprescott added the Network az network vnet/lb/nic/dns/etc... label Oct 1, 2018
@tjprescott tjprescott added this to the Sprint 46 milestone Oct 1, 2018
@@ -2197,7 +2196,7 @@ def create_nic_ip_config(cmd, resource_group_name, network_interface_name, ip_co
'load_balancer_backend_address_pools': load_balancer_backend_address_pool_ids,
'load_balancer_inbound_nat_rules': load_balancer_inbound_nat_rule_ids,
'private_ip_address': private_ip_address,
'private_ip_allocation_method': private_ip_address_allocation,
'private_ip_allocation_method': 'Static' if private_ip_address else 'Dynamic'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, will dynamic work if private_ip_address is None?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@tjprescott tjprescott merged commit a537f49 into Azure:dev Oct 1, 2018
@tjprescott tjprescott deleted the IpConfigHelp branch October 1, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IP Config Allocation Update
3 participants