[Core] Update core for latest knack #8940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
commented
Apr 1, 2019
| @@ -10,6 +10,7 @@ | |||
| from azure.cli.core.profiles import ResourceType | |||
|
|
|||
| from knack.log import get_logger | |||
| from knack.validators import DefaultStr, DefaultInt # pylint: disable=unused-import | |||
There was a problem hiding this comment.
Avoid the breaking change to core that would occur if these were removed.
adewaleo
reviewed
Apr 1, 2019
| overrides.settings['default'] = DefaultStr(config_value) | ||
| overrides.settings['required'] = False | ||
| # same blunt mechanism like we handled id-parts, for create command, no name default | ||
| if self.name.split()[-1] == 'create' and overrides.settings.get('metavar', None) == 'NAME': |
There was a problem hiding this comment.
Did we ignore defaults for create commands previously?
adewaleo
reviewed
Apr 1, 2019
| @@ -11,4 +11,3 @@ | |||
| CONFIG_FILE_NAME = 'config' | |||
| GLOBAL_CONFIG_PATH = os.path.join(GLOBAL_CONFIG_DIR, CONFIG_FILE_NAME) | |||
| ENV_VAR_PREFIX = 'AZURE' | |||
| DEFAULTS_SECTION = 'defaults' | |||
There was a problem hiding this comment.
I guess this is a "breaking change" but I suppose it can't be helped.
marstr
reviewed
Apr 1, 2019
src/azure-cli-core/setup.py
Outdated
| @@ -59,7 +59,7 @@ | |||
| 'colorama>=0.3.9', | |||
| 'humanfriendly>=4.7', | |||
| 'jmespath', | |||
| 'knack>=0.5.3', | |||
| 'knack>=0.5.4', | |||
There was a problem hiding this comment.
While we're at it, should we use the ~= operator instead of the >= operator? Especially when libraries are in the 0 band, we want to protect ourselves from breaking changes (even if we're the ones who would be doing it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knack now contains the configure_defaults logic. This moves the CLI toward relying on that implmentation.
This checklist is used to make sure that common guidelines for a pull request are followed.
[N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.