Add system generated keys for permissions and items #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I sent a follow up PR with some suggested changes: #84 |
christopheranderson
suggested changes
Jul 30, 2018
src/client/Item/Item.ts
Outdated
| @@ -68,7 +69,9 @@ export class Item { | |||
| if ((!options || !options.partitionKey) && this.primaryKey) { | |||
| options.partitionKey = this.primaryKey; | |||
| } | |||
| const response = await (this.client.documentClient.readDocument(this.url, options) as Promise<Response<T>>); | |||
| const response = await (this.client.documentClient.readDocument(this.url, options) as Promise< | |||
| Response<T & ItemBody> | |||
There was a problem hiding this comment.
Unless we also change the <any> signature, this won't be seen.
christopheranderson
approved these changes
Jul 30, 2018
|
|
christopheranderson
pushed a commit
that referenced
this pull request
Jul 31, 2018
* Add system generated keys for permissions and items * Add ItemDefinition (#84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds system generated keys to the return bodies for
PermissionandItemcalls@christopheranderson any thoughts on the approach of using
<T & ItemBody>for items? Open to other suggestions, this was the option that made sense to me in the TS docs but seems like<ItemBody<T = any>>could also work.