Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jar directory locations and versions in config code #86

Merged
merged 3 commits into from
Jul 29, 2017
Merged

Update jar directory locations and versions in config code #86

merged 3 commits into from
Jul 29, 2017

Conversation

tknandu
Copy link
Contributor

@tknandu tknandu commented Jul 25, 2017

Updating the configurations to use the most recent version of the jars and also ensure the directory location of the jars matches that specified in the wiki

@msftclas
Copy link

@tknandu,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@tknandu, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

Copy link
Contributor

@dennyglee dennyglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you re-run the Spark Connector (Scala) notebook it's in entirety and change the JARs configuration to include all four JARs? Could you also include updating the PySpark version? Thanks!

@dennyglee
Copy link
Contributor

dennyglee commented Jul 26, 2017

@tknandu Oh and I forgot to note that the DocumentDB version of the notebook doesn't need to change as we'll deprecate this per #87 - thanks!

@tknandu
Copy link
Contributor Author

tknandu commented Jul 26, 2017

Have addressed your comments @dennyglee
The PR now addresses the following issues - #85 , #87 , #88

@tknandu tknandu merged commit bf69cd8 into Azure:master Jul 29, 2017
Copy link
Contributor

@dennyglee dennyglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants