Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/validate-correctness-and-completeness-of-readmemd-for-all-modules #167

Merged
merged 44 commits into from
Feb 28, 2023
Merged

Improvement/validate-correctness-and-completeness-of-readmemd-for-all-modules #167

merged 44 commits into from
Feb 28, 2023

Conversation

nachoalonsoportillo
Copy link
Contributor

No description provided.

@nachoalonsoportillo
Fix dexcription of network_profile variable for aks-cluster
13d4674
@nachoalonsoportillo
Remove provider block from main.tf for cognitive-search
ac2b5c3
@nachoalonsoportillo
Fix formatting of some multi-line descriptions
5896ea4
@github-actions
terraform-docs: automated action
27cb3e1
@github-actions
terraform-docs: automated action
cfcc2eb
@github-actions
terraform-docs: automated action
c573253
@github-actions
terraform-docs: automated action
1e74ac6
@nachoalonsoportillo
Re-enable trigger for pull_request event but comment-out Terratest job
d5fb462
@nachoalonsoportillo
Change FW and LB variable descriptions a bit
e0e599f
@github-actions
terraform-docs: automated action
a9c5bed
@nachoalonsoportillo
Merge branch 'improvement/validate-correctness-and-completeness-of-re…
7a3f256 
…admemd-for-all-modules' of https://github.com/Azure/azure-data-labs-modules into improvement/validate-correctness-and-completeness-of-readmemd-for-all-modules
@github-actions
terraform-docs: automated action
a16df20
@github-actions
terraform-docs: automated action
3946b9b
@github-actions
terraform-docs: automated action
849e08f
@nachoalonsoportillo
Amend workflow
13f062e
@nachoalonsoportillo
Merge branch 'improvement/validate-correctness-and-completeness-of-re…
5e64c50 
…admemd-for-all-modules' of https://github.com/Azure/azure-data-labs-modules into improvement/validate-correctness-and-completeness-of-readmemd-for-all-modules
@nachoalonsoportillo
Amend workflows
53c314c
@github-actions
terraform-docs: automated action
90fa1c1
@github-actions
terraform-docs: automated action
5771b3a
@github-actions
terraform-docs: automated action
6292e0d
@github-actions
terraform-docs: automated action
f981d26
@github-actions
terraform-docs: automated action
77229be
@github-actions
terraform-docs: automated action
2f6d6d5
@github-actions
terraform-docs: automated action
9d4a062
@github-actions
terraform-docs: automated action
74e5fc5
@github-actions
terraform-docs: automated action
df6b095
@github-actions
terraform-docs: automated action
7ac4402
@github-actions
terraform-docs: automated action
3d85c20
@github-actions
terraform-docs: automated action
c84c8a9
@nachoalonsoportillo nachoalonsoportillo marked this pull request as ready for review February 19, 2023 16:00
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo nachoalonsoportillo temporarily deployed to acctests February 28, 2023 14:56 — with GitHub Actions Inactive
@nachoalonsoportillo
Copy link
Contributor Author

@nachoalonsoportillo why hdinsight-{*}, log-analytics-cluster and powerbi-embedded tests are back activated here?

They are all deactivated now. Thanks for the catch!

@nachoalonsoportillo nachoalonsoportillo merged commit bb8f528 into main Feb 28, 2023
@nachoalonsoportillo nachoalonsoportillo deleted the improvement/validate-correctness-and-completeness-of-readmemd-for-all-modules branch February 28, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murggu murggu murggu approved these changes

@jdocampo jdocampo Awaiting requested review from jdocampo

@waltergrasselli waltergrasselli Awaiting requested review from waltergrasselli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate correctness and completeness of Readme.md for all modules
2 participants
@nachoalonsoportillo @murggu