Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureDLFileSystem does not follow PythonFilesystem Interface #242

Closed
yshahin opened this issue Sep 17, 2018 · 4 comments
Closed

AzureDLFileSystem does not follow PythonFilesystem Interface #242

yshahin opened this issue Sep 17, 2018 · 4 comments

Comments

@yshahin
Copy link

yshahin commented Sep 17, 2018

Description

Outline the issue here:
Working with Bonobo lib I am unable to utilize the library cause it doesn't conform the PythonFilesystem Interface.
Current problem facing is "open() got an unexpected keyword argument 'encoding'"

Reproduction Steps

** Enumerate the steps to reproduce the issue here:**
Use AzureDLFileSystem instance as a bonobo file system service

Environment summary

SDK Version: What version of the SDK are you using? (pip show azure-datalake-store)
Answer here: 0.0.31

Python Version: What Python version are you using? Is it 64-bit or 32-bit?
Answer here: 64-bit v3.6.5

OS Version: What OS and version are you using?
Answer here: Windows

Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Answer here: Git Bash

@akharit
Copy link
Member

akharit commented Sep 17, 2018

@yshahin Thanks for pointing the issue!

Can you please provide some stub code that reproduces the error?

@akharit
Copy link
Member

akharit commented Sep 17, 2018

This might be related to #238 and #232.

@yshahin
Copy link
Author

yshahin commented Sep 17, 2018

Yes they are related

@akharit
Copy link
Member

akharit commented Nov 2, 2018

Closing as it requires text mode support i.e encoding, while adls only provides binary support.

@akharit akharit closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants