Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache leak #203

Merged
merged 7 commits into from
Feb 7, 2018
Merged

Cache leak #203

merged 7 commits into from
Feb 7, 2018

Conversation

milanchandna
Copy link
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

Fixed read issue where whole file was cached while doing positional reads #198

General Guidelines

  • [ x] The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
  • [x ] The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • [ x] Links to associated bugs, if any, are in the description.

@coveralls
Copy link

coveralls commented Feb 6, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.6%) to 84.831% when pulling f016cf1 on cache-leak into d18e47d on master.

asikaria-msft
asikaria-msft approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@asikaria-msft asikaria-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milanchandna milanchandna merged commit fa69e4b into master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikaria-msft asikaria-msft asikaria-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@milanchandna @coveralls @asikaria-msft