Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for external token not having retry options #256

Merged
merged 4 commits into from Nov 5, 2018

Conversation

akharit
Copy link
Member

@akharit akharit commented Nov 2, 2018


This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

Reverts some changes introduced in 0.0.35. tokens are used across azure ecosystem, and to maintain compatibility, we can not modify that DataLakeCredentials class substantially. Added retries only for check_token(). While this is more coarse grained, this will work with tokens obtained from other azure libraries. #255

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.

@coveralls
Copy link

coveralls commented Nov 2, 2018

Coverage Status

Coverage increased (+0.1%) to 86.486% when pulling c0d331a on akharit-commonCred-fix into e1605c3 on master.

@akharit akharit merged commit 0adf4dd into master Nov 5, 2018
@akharit akharit deleted the akharit-commonCred-fix branch November 6, 2018 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants