Skip to content

Commit

Permalink
Addresses PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
wbreza committed Jan 24, 2024
1 parent 54f4e9c commit 71fc302
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
3 changes: 1 addition & 2 deletions cli/azd/cmd/container.go
Expand Up @@ -468,7 +468,6 @@ func registerCommonDependencies(container *ioc.NestedContainer) {
container.MustRegisterSingleton(maven.NewMavenCli)
container.MustRegisterSingleton(helm.NewCli)
container.MustRegisterSingleton(kustomize.NewCli)
container.MustRegisterSingleton(kustomize.NewKustomize)
container.MustRegisterSingleton(npm.NewNpmCli)
container.MustRegisterSingleton(python.NewPythonCli)
container.MustRegisterSingleton(swa.NewSwaCli)
Expand All @@ -484,7 +483,7 @@ func registerCommonDependencies(container *ioc.NestedContainer) {

// Service Targets
serviceTargetMap := map[project.ServiceTargetKind]any{
"": project.NewAppServiceTarget,
project.NonSpecifiedTarget: project.NewAppServiceTarget,
project.AppServiceTarget: project.NewAppServiceTarget,
project.AzureFunctionTarget: project.NewFunctionAppTarget,
project.ContainerAppTarget: project.NewContainerAppTarget,
Expand Down
4 changes: 2 additions & 2 deletions cli/azd/pkg/helm/cli.go
Expand Up @@ -26,12 +26,12 @@ func (cli *Cli) Name() string {
return "helm"
}

// Returns the installation URL to install the K8s CLI
// Returns the installation URL to install the Helm CLI
func (cli *Cli) InstallUrl() string {
return "https://aka.ms/azure-dev/helm-install"
}

// Checks whether or not the K8s CLI is installed and available within the PATH
// Checks whether or not the Helm CLI is installed and available within the PATH
func (cli *Cli) CheckInstalled(ctx context.Context) error {
if err := tools.ToolInPath("helm"); err != nil {
return err
Expand Down
4 changes: 2 additions & 2 deletions cli/azd/pkg/kustomize/cli.go
Expand Up @@ -26,12 +26,12 @@ func (cli *Cli) Name() string {
return "kustomize"
}

// Returns the installation URL to install the K8s CLI
// Returns the installation URL to install the Kustomize CLI
func (cli *Cli) InstallUrl() string {
return "https://aka.ms/azure-dev/kustomize-install"
}

// Checks whether or not the K8s CLI is installed and available within the PATH
// Checks whether or not the Kustomize CLI is installed and available within the PATH
func (cli *Cli) CheckInstalled(ctx context.Context) error {
if err := tools.ToolInPath("kustomize"); err != nil {
return err
Expand Down
1 change: 1 addition & 0 deletions cli/azd/pkg/project/service_target.go
Expand Up @@ -18,6 +18,7 @@ import (
type ServiceTargetKind string

const (
NonSpecifiedTarget ServiceTargetKind = ""
AppServiceTarget ServiceTargetKind = "appservice"
ContainerAppTarget ServiceTargetKind = "containerapp"
AzureFunctionTarget ServiceTargetKind = "function"
Expand Down

0 comments on commit 71fc302

Please sign in to comment.