Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate database(Cosmos, Azure SQL etc) security of all templates #1142

Open
jongio opened this issue Nov 11, 2022 · 3 comments
Open

Evaluate database(Cosmos, Azure SQL etc) security of all templates #1142

jongio opened this issue Nov 11, 2022 · 3 comments
Assignees
Labels
bug Something isn't working security templates
Milestone

Comments

@jongio
Copy link
Member

jongio commented Nov 11, 2022

No description provided.

@jongio jongio self-assigned this Nov 11, 2022
@TWolverson
Copy link

I would like to mention in this context that https://github.com/Azure-Samples/todo-csharp-sql effectively disables the SQL firewall by adding an allow-all rule, which is not mentioned anywhere in the readme. Given that this is going to be taken as a reference solution I'd argue this is effectively putting a bomb in code that people will trust is aligned to best practices which it very much is not.

@tonyeung
Copy link

tonyeung commented Dec 6, 2022

Also consider adding how the password generation works in the security section. #994 has the source code. From what I'm reading, azd calls this command internally, always expects a kv name and key, looks up the secret using the key provided from kv, if it exists, returns it, else generates a new one and returns that

@rajeshkamal5050 rajeshkamal5050 assigned weikanglim and unassigned jongio Jan 18, 2023
@rajeshkamal5050 rajeshkamal5050 added this to the Future Release milestone Jan 18, 2023
@rajeshkamal5050 rajeshkamal5050 added the bug Something isn't working label Feb 6, 2023
@rajeshkamal5050 rajeshkamal5050 changed the title Evaluate security of our Azure SQL templates Evaluate database(Cosmos, Azure SQL etc) security of all templates Apr 13, 2023
@rajeshkamal5050
Copy link

Not a must-fix for GA. Moving to Germanium.

Since Bicep related efforts i.e, moving bicep modules(azure-dev -> awesome-azd), following best practices, moving into bicep registry will be handled in Germanium.

@savannahostrowski @ellismg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security templates
Projects
None yet
Development

No branches or pull requests

5 participants