[Issue] Maybe 'azd down' should remove KEY_VAULT* from .env ?

[pamelafox]

• Make sure you've installed the latest version using instructions in the wiki

Output from azd version
azd version 0.9.0-beta.2 (commit afa7ac6)

Describe the bug

I just completely took down my resources using 'azd down'. I then ran 'azd up' and got deployment failed:

ERROR: deployment failed: failing invoking action 'provision', planning deployment: planning infrastructure provisioning: creating parameters file: substituting command output inside parameter file: reading secret 'POSTGRESPASSWORD' from vault 'relecloudca5zjvr7-vault': getting key vault secret: Get "https://relecloudca5zjvr7-vault.vault.azure.net/secrets/POSTGRESPASSWORD/?api-version=7.3": dial tcp: lookup relecloudca5zjvr7-vault.vault.azure.net: no such host

I presume that's because my .env still has values for AZURE_KEY_VAULT_NAME and AZURE_KEY_VAULT_ENDPOINT. Perhaps calling 'azd down' should remove those values from the .env file?

I will manually do it, which should work.

To Reproduce

On a repo with ACA support, try azd up, azd down and then azd up:
https://github.com/pamelafox/azure-django-postgres-aca-fork

Expected behavior

I expect it to start from scratch after I've down'ed it all.

Environment

Mac OS X M1 VS Code

[ellismg]

Surprising - The intention was that azd down would remove all the outputs from a previous deploy:

azure-dev/cli/azd/cmd/down.go

Lines 116 to 130 in e797ff8

	destroyOptions := provisioning.NewDestroyOptions(a.flags.forceDelete, a.flags.purgeDelete)
	destroyResult, err := infraManager.Destroy(ctx, destroyOptions)
	if err != nil {
	return nil, fmt.Errorf("deleting infrastructure: %w", err)
	}
	// Remove any outputs from the template from the environment since destroying the infrastructure
	// invalidated them all.
	for outputName := range destroyResult.Outputs {
	a.env.DotenvDelete(outputName)
	}
	if err := a.env.Save(); err != nil {
	return nil, fmt.Errorf("saving environment: %w", err)
	}

In this case, AZURE_KEY_VAULT_NAME and AZURE_KEY_VAULT_ENDPOINT are outputs from main.bicep, so I would have expected them to be deleted. Perhaps we are not returning the correct set of outputs from the the provider?