Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[env select] - validate env name exists #2306

Closed
vhvb1989 opened this issue May 25, 2023 · 1 comment · Fixed by #2471
Closed

[env select] - validate env name exists #2306

vhvb1989 opened this issue May 25, 2023 · 1 comment · Fixed by #2471
Assignees
@ellismg
Labels
cli core
Milestone
July 2023 - 1.1.0

Comments

@vhvb1989
Copy link
Member

When running azd env select foo , azd is not validating that foo is an existing environment. Azd is setting the env name to foo without creating the environment. This causes that running azd provision next would ask if you want to create the foo environment.

Example:
image

Expected:
Should azd fail if azd env select receives one environment name which does not exists?
@ghost ghost added the needs-triage For new issues label May 25, 2023
@ellismg
Copy link
Member

ellismg commented May 25, 2023

Should azd fail if azd env select receives one environment name which does not exists?

Yeah, this feels like a reasonable thing for us to be doing here.

@rajeshkamal5050 rajeshkamal5050 added this to the July 2023 - 1.1.0 milestone May 31, 2023
@ghost ghost removed the needs-triage For new issues label May 31, 2023
@rajeshkamal5050 rajeshkamal5050 mentioned this issue Jun 19, 2023
Closed
@ellismg ellismg assigned ellismg and unassigned hemarina Jun 30, 2023
ellismg added a commit to ellismg/azure-dev that referenced this issue Jun 30, 2023
@ellismg
Validate environment exists when running azd env select
0bf4e3d 
Also, update the help text for `azd env new` to call out that the new
enviromnet is set as the default environment once it is created.

Fixes Azure#2306
@ellismg ellismg mentioned this issue Jun 30, 2023
Merged
ellismg added a commit that referenced this issue Jul 5, 2023
@ellismg
Validate environment exists when running azd env select (#2471)
8647e5c 
Also, update the help text for `azd env new` to call out that the new
environment is set as the default environment once it is created.

Fixes #2306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellismg ellismg

Labels
cli core
Projects
None yet
Milestone
July 2023 - 1.1.0
Development

Successfully merging a pull request may close this issue.

Validate environment exists when running azd env select ellismg/azure-dev
4 participants
@ellismg @rajeshkamal5050 @vhvb1989 @hemarina