Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using the GH CLI auth UX in Codespaces #2332

Closed
savannahostrowski opened this issue May 31, 2023 · 5 comments · Fixed by #2337
Closed

Investigate using the GH CLI auth UX in Codespaces #2332

savannahostrowski opened this issue May 31, 2023 · 5 comments · Fixed by #2337

Comments

@savannahostrowski
Copy link
Contributor

savannahostrowski commented May 31, 2023

The GH CLI has a slightly nicer auth flow than azd in Codespaces today.

They show a user a code, tell them to copy it and then hit enter to open the browser to paste it in. This is a slightly more streamlined UX, can we adopt it?

@ghost ghost added the needs-triage For new issues label May 31, 2023
@savannahostrowski
Copy link
Contributor Author

@vhvb1989 Have you considered this? Is this possible?

@ghost ghost removed the needs-triage For new issues label May 31, 2023
@vhvb1989
Copy link
Member

@savannahostrowski that's the device-code flow
We already do that in codespaces.

@savannahostrowski
Copy link
Contributor Author

Nah, this is different. We do a very similar flow but require a user to either control click the URL or copy-paste the URL into another browser window.

GH CLI just asks the user to hit enter and brings them to another window. It's a little more streamlined but it'd also be nice to have the authentication flow as them.

@vhvb1989
Copy link
Member

vhvb1989 commented Jun 1, 2023

@savannahostrowski , it was easy to make the change. Made a PR for you.

@savannahostrowski
Copy link
Contributor Author

This is the Victor way! I file an issue and by end of day, there's a PR! Always going above and beyond :D

Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants