New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update device-code login flow with auto-open-browser #2337
Conversation
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Matt Ellis <matt.ellis@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushing back slightly on the introduction of the PausedConsole type. I think we should just be modifying the console interface to add a new method instead of solving the problem the way you did here.
But I could be missing a larger issue here, so if there's something else that pushed you in this direction, I'd love to learn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - one small comment about dropping the error on the floor.
Thanks for this fix - I think the interaction is much better!
@ellismg , Updated this as per your preference :) My preference is decorator pattern when adding functionality details like what it was needed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's double check on verbiage here, and I had minor feedback on error handling, but otherwise the changes look good.
Does this match what gh uses for wording? We could always just copy that |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference (preview)
|
fix: #2332
Updating
device code
login flow to:Images from the flow:
azd - device code - login flow - waiting before openning browser
After browser login: