Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App fingerprinting finetuning/polish #2654

Closed
4 of 14 tasks
savannahostrowski opened this issue Aug 24, 2023 · 1 comment · Fixed by #2756
Closed
4 of 14 tasks

App fingerprinting finetuning/polish #2654

savannahostrowski opened this issue Aug 24, 2023 · 1 comment · Fixed by #2756
Assignees
Labels
cli golden-path Improvements to the getting started experience + golden path (local dev -> first deploy)
Milestone

Comments

@savannahostrowski
Copy link
Contributor

savannahostrowski commented Aug 24, 2023

Using this basic app for a case study https://github.com/savannahostrowski/cinest

Updates we should make...

Before 9/20

  • The standard .gitignore for Python automatically adds lib/ as this is a subdirectory in venv. We should update our lib/ in infra/ to not conflict with this naming
  • Consider adding common troubleshooting at the top of next-steps.md
    • Call out that the ports may need to be updated
    • Env variables used in api.bicep need to match the app right away)
    • Needed to update paths for API requests in front-end to use back-end container URL (a bit of a chicken and egg problem)
    • Explore how we can better direct users to update package.json or similar in their app to add what Oryx expects (e.g. a start script is needed and there's no Google-able results for users to debug this). At the very least, we should add to the top of next-steps.md
  • Consider updating to check for asyncpg for Postgres DB detection

By Ignite:

Post Ignite:

  • Support for managed add-ons - e.g. Redis running in container
  • Support for overriding recommended services
@savannahostrowski savannahostrowski added cli golden-path Improvements to the getting started experience + golden path (local dev -> first deploy) labels Aug 24, 2023
@savannahostrowski savannahostrowski added this to the Germanium milestone Aug 24, 2023
@savannahostrowski savannahostrowski changed the title App fingerprinting catch-all App fingerprinting finetuning/polish Sep 11, 2023
@weikanglim
Copy link
Contributor

Typing on mobile since home internet isn't working, apologies for the conciseness and simplistic formatting:

  • Ports and DB. We may consider prompting early on for the desired values, as this is more aligned with progressive disclosure than the alternative. In dotnet, we can safely provide a default. If we want this experience to be better, we'd also want to offer different types of variable settings. A single psql connection string or discrete db properties.
  • Back-end reference: We do provide an env var for the front end to reference the backend in the form of API_BASE_URL. This could be also exported to local env and have instructions in nextsteps.md on how to consume.
  • Oryx treatment of static front-ends: this needs discussion with Oryx team. The current flow is not idiomatic and actually goes against most dev expectations.
  • KeyVault CI/CD: may be able to adjust the bicep to PATCH instead of PUT. I suspect the same issue currently exists with other todo apps that uses secretOrRandomPassword.
  • Secrets: there's two pathways, one is storing in CI provider and referencing via env var as done above. Alternative is to add it to the KeyVault. There's an overarching question here on whether azd's over-simplistic assumption that you can provision secrets and app in a single bicep deployment is the way to go long term. This may deserve it's own write-up.

weikanglim added a commit that referenced this issue Sep 18, 2023
Make a few minor enhancements to simplified init workflow:

1. Add heuristic detection for various async python and javascript libraries
2. Fix lint error for unused `apiUrls` for frontend only app
3. Rename directory `lib` -> `modules` to avoid being accidentally excluded by python .gitignore
4. Update next-steps readme

Fixes #2654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli golden-path Improvements to the getting started experience + golden path (local dev -> first deploy)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants