-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codespaces developer environments support #370
Comments
Can we outline more specifically what does and does not work in Codespaces today? Is it just that you can't login via Azure? That's the problem I ran into. Is this the only issue? |
@v-xuto - Can you please do a full test pass on Codespaces and file any issues discovered? Thanks! |
@jongio We have finished the manual tests in the Test results in
Notes:
|
Goals:
Codespace scenario:
Codespaces support matrix:
Repo List:
Notes:
|
Are we still investigating getting |
These are mostly notes to myself. I'm installing |
Sweet - thanks Daniel! |
Further discussion with @philliphoff on Friday yielded a few more pieces of information.
To fix this we'd need to: (#918)
|
When validating "deployed API" scenarios in at least app service (and probably others) there are CORS policies set which prevent the possibility of running the web app in GH codespaces against an API that has been deployed to app services. |
@savannahostrowski With all the recent fixes by @danieljurek and myself, here's what works and doesn't work: Codespaces (Desktop and Web)1 outstanding issue: #922 - Python debugging doesn't work. This happens on local Codespaces on DesktopWorking:
Not working:
Codespaces on WebWorking:
Not working:
Without VSCode debugging for front-end JS, the Codespaces in browser experience still feels like an incomplete experience. Thus, I would rather not do #918 and tell users the story that:
There's also other considerations about supporting VSCode in browser that gives me pause:
|
Also leaving a note here for the record. I think Codespaces is ready to announce in January (when we have our next big monthly release). The issues noted here are not, IMO, azd issues but rather issues/limitations with Codespaces in the browser all up. See https://code.visualstudio.com/docs/remote/codespaces ...notably, the limitations section where they denote that "Code running in a browser cannot launch another browser instance in debug mode for security reasons.". They encourage users to use Codespaces running locally in VS Code for that use case. |
One last thing: the plan of record is still to include azd in the Codespaces image right? So that a user doesn't have to install the tool and things just work ™️ (e.g. I can fork a template, open in a Codespace and go right to right-click azure.yaml to run |
That works today. |
Are you sure? I just tried it out and was still prompted to install azd (I got a toast notification) before azd up could run (and then subsequently prompted to install az, which is being remedied in another way) |
Screenshots pls |
@savannahostrowski I think you're likely hitting microsoft/vscode#165292. I believe VSCode has race conditions when initially launching the devcontainer in Codespaces. It's a false-positive prompt that is a bug in VSCode. |
@weikanglim Ah yeah, I just tried again on another template and I didn't run into it again. Seems like I can However, I did run into an interesting error. On I tried removing the description when I create the fork but this persists. It's likely a GitHub bug but not sure where that's coming from. I was able to just open a Codespace directly on the template to get around this. |
@savannahostrowski That's odd. I was able to create a fork and open in Codespace. If I needed to guess, that error is indeed from our GitHub repository's descriptions being over the validated length -- this either is a new requirement, or we had created this through our innersource Portal which may have bypassed the requirements. The repository description on https://github.com/Azure-Samples/todo-python-mongo-aca is:
Length = 361 I wonder if we can shorten the description to the thing that is different about this repository vs. others. The full description is still in the readme file.
|
Filed a bug on template description: #1199 This is ready for announcing in January. I've tagged with newsworthy. |
This can be closed. New issue to document login behavior changes: #1216 |
No description provided.
The text was updated successfully, but these errors were encountered: