-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage ACR build for docker container image builds #509
Comments
I wonder if we should do this by default. This would let us stop depending on Docker for cases where you were not concerned about running the application locally. As a windows user, I'd actually prefer this to Docker Desktop, I think, Are there downsides to making this default, @Gordonby? I could imagine the remote build environment has some additional restrictions vs local, perhaps shipping the entire build context by default ends up being more traffic than just pushing up the built layers, and maybe that "no-op" builds take longer just because the roundtrip time to the remote build service. BTW - Long term we would like to remove the dependency we have on the |
I think the only downside is for mature docker users who prefer the local experience, who have potentially large images already downloaded locally and in their ACR. IMO Acr build would be a good default if Acr is already the default registry. I have Docker installed locally but the daemon does not start with machine startup, only on demand... so I always get caught out 😅 |
When we design support for toggling between an ACR build and a local docker build, it might be good for us to think about the way that toggle is manifested in the system and if a similar strategy could be used for folks on App Service who want to switch between local builds and remote builds with oryx or something. At some level these problems look "the same". |
This is still an open issue, right? as in, the only way to build an image with azd is if you have Docker running locally, correct? @andredewes is trying to decide how to add support for image building to https://github.com/Azure-Samples/openai-aca-lb and doesn't want to use the azd mechanism if it requires Docker (which is reasonable), so the current plan is to use a postprovision hook with |
I looked into a how
https://gist.github.com/ellismg/08e4475cf144629e391ff0705aee589a is a small translation of the happy path of this logic into go. To produce the context, I checked out the Running the linked gist produced output like the following:
Going to start working on turning this from an exploratory hack into something that we could push into |
This change sketches out support for using the ACR remote build feature and uses it the the `containerapp` service target. To use it, add `remoteBuild: true` to the `docker` member of a `service` in `azure.yaml` Fixes Azure#509
This change sketches out support for using the ACR remote build feature and uses it the the `containerapp` service target. To use it, add `remoteBuild: true` to the `docker` member of a `service` in `azure.yaml` Fixes Azure#509
When using Azure Container Apps with azd, sometimes developers don't have the local tooling to build docker containers.
Reasons/Situations to avoid local docker builds
The Azure Container Registry build capability can be used to queue a local context and push it to the registry in one step.
https://docs.microsoft.com/en-us/cli/azure/acr?view=azure-cli-latest#az-acr-build
The text was updated successfully, but these errors were encountered: