Simplify color processing on Windows #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, the Windows console has used out of band signaling for control color information, unlike *nix where control characters are added to the text to control what color it is printed in and other formatting information. For a long time, Windows could not cope with the *nix strategy, leading to things like `colorable.NewColorableStdout()` and friends which tried to provide streams which would interpret ANSI escape sequences and call the corresponding Win32 methods to change colors as it rendered the text. This process was very fragile and would lead to cases where we'd end up not using `colorable.NewColorableStdout()` and then when run on windows in the legacy console host we'd see these escape codes get printed. Windows now supports processing these escape sequences. Enable that behavior and get out of the `colorable.NewColorableStdout()` game. Fixes Azure#1058
ellismg
requested review from
wbreza,
vhvb1989,
hemarina,
jongio and
weikanglim
as code owners
ghost
assigned 
|
Without these changes:
With these changes:
Note that if you were using Windows Terminal, you wouldn't have hit this issue, as it turns this behavior on by default. |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsStandalone Binary
Container |
wbreza
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, the Windows console has used out of band signaling for control color information, unlike *nix where control characters are added to the text to control what color it is printed in and other formatting information.
For a long time, Windows could not cope with the *nix strategy, leading to things like
colorable.NewColorableStdout()and friends which tried to provide streams which would interpret ANSI escape sequences and call the corresponding Win32 methods to change colors as it rendered the text.This process was very fragile and would lead to cases where we'd end up not using
colorable.NewColorableStdout()and then when run on windows in the legacy console host we'd see these escape codes get printed.Windows now supports processing these escape sequences. Enable that behavior and get out of the
colorable.NewColorableStdout()game.Fixes #1058