Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add java postgresql todo terraform template #1792

Merged
merged 13 commits into from
Apr 28, 2023
Merged

Add java postgresql todo terraform template #1792

merged 13 commits into from
Apr 28, 2023

Conversation

fangjian0423
Copy link
Contributor

Todo template with a Java API and Azure Database for PostgreSQL - Flexible Server on Azure App Service. Including:

  • Terraform
    • PostgreSQL
    • AppService Java
    • PostgreSQL Passwordless
  • Repoman for java-postgresql
  • Java-postgresql project

@ghost ghost assigned fangjian0423 Mar 24, 2023
HadwaAbdelhalem
HadwaAbdelhalem requested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@HadwaAbdelhalem HadwaAbdelhalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments mostly on the terraform code side.

templates/common/infra/terraform/core/database/postgresql/postgresql.tf Show resolved Hide resolved
templates/common/infra/terraform/core/database/postgresql/postgresql.tf Outdated Show resolved Hide resolved
templates/common/infra/terraform/core/database/postgresql/postgresql.tf Outdated Show resolved Hide resolved
...lates/common/infra/terraform/core/host/appservice/appservicejava/appservicejava_variables.tf Outdated Show resolved Hide resolved
...lates/common/infra/terraform/core/host/appservice/appservicejava/appservicejava_variables.tf Outdated Show resolved Hide resolved
...lates/common/infra/terraform/core/host/appservice/appservicejava/appservicejava_variables.tf Outdated Show resolved Hide resolved
...lates/common/infra/terraform/core/host/appservice/appservicejava/appservicejava_variables.tf Outdated Show resolved Hide resolved
templates/todo/projects/java-postgresql/.repo/terraform/repo.yaml Outdated Show resolved Hide resolved
templates/todo/projects/java-postgresql/.repo/terraform/infra/output.tf Outdated Show resolved Hide resolved
@fangjian0423 fangjian0423 mentioned this pull request Apr 4, 2023
Closed
@fangjian0423
Copy link
Contributor Author

hi @HadwaAbdelhalem , could you please help to look again?

@fangjian0423
Copy link
Contributor Author

@rajeshkamal5050 could you pls take a look? thanks.

@rajeshkamal5050
Copy link

rajeshkamal5050 commented Apr 25, 2023 •
edited
Loading

@v-xuto can you validate, test this template and report back?

@v-xuto
Copy link
Member

v-xuto commented Apr 25, 2023

@v-xuto can you validate, test this template and report back?

@rajeshkamal5050 We have completed the test of these 3 templates (todo-java-mongo-aca, todo-java-mongo and todo-java-postgresql-terraform ), no issue found.

@HadwaAbdelhalem
Copy link
Contributor

Terraform code looks good to me. @fangjian0423 can you run terraform fmt cmd on all your terraform modules to fix the files format

@azure-sdk
Copy link
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: todo-java-mongo-aca

Remote: azure-samples-staging

Branch: pr/1792

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo-aca -b pr/1792

View Changes | Compare Changes

Project: todo-java-mongo

Remote: azure-samples-staging

Branch: pr/1792

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo -b pr/1792

View Changes | Compare Changes

Project: todo-java-postgresql-terraform

Remote: azure-samples-staging

Branch: pr/1792

You can initialize this project with:

azd init -t Azure-Samples/todo-java-postgresql-terraform -b pr/1792

View Changes | Compare Changes

@fangjian0423
Copy link
Contributor Author

Terraform code looks good to me. @fangjian0423 can you run terraform fmt cmd on all your terraform modules to fix the files format

done @HadwaAbdelhalem , @rajeshkamal5050 looks like everything has been done for this PR. Can we merge it?

This was referenced Apr 27, 2023
Closed
Closed
@jongio
Copy link
Member

jongio commented Apr 27, 2023

🚢

@fangjian0423 fangjian0423 merged commit 37b58ed into Azure:main Apr 28, 2023
@rajeshkamal5050 rajeshkamal5050 mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongio jongio jongio approved these changes

@HadwaAbdelhalem HadwaAbdelhalem HadwaAbdelhalem approved these changes

@wbreza wbreza Awaiting requested review from wbreza wbreza is a code owner

@hattan hattan Awaiting requested review from hattan

@rajeshkamal5050 rajeshkamal5050 Awaiting requested review from rajeshkamal5050

@weikanglim weikanglim Awaiting requested review from weikanglim

@ellismg ellismg Awaiting requested review from ellismg

@vhvb1989 vhvb1989 Awaiting requested review from vhvb1989

@hemarina hemarina Awaiting requested review from hemarina

Assignees

@fangjian0423 fangjian0423

Labels
templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fangjian0423 @rajeshkamal5050 @v-xuto @HadwaAbdelhalem @azure-sdk @jongio