-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudshell auth #1807
Cloudshell auth #1807
Conversation
.gitignore progress on manager.go proving concept remove test template
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference (preview)
|
Succeeds in local CloudShell testing for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please wait after we release 0.8 to merge? (4/10)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieljurek Lets merge this change post 0.8 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here, @danieljurek!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice job!
Retrieves credentials using the token endpoint on CloudShell https://learn.microsoft.com/en-us/azure/cloud-shell/msi-authorization. The endpoint handles caching of the token so it can be requested without having to handle caching logic inside the application.
Also reports telemetry that it's in CloudShell. This detection is done using an environment variable
AZD_IN_CLOUDSHELL
whose name we can control.I had to refactor some logic around JWT parsing to prevent a circular dependency in
azureutil