-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure Spring Apps service target #1808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fangjian0423!
This looks like it's moving in the right direction! I do have a few changes I'd like to see before landing.
I'm wondering what pushed you towards a container based deployment instead of a jar or build pack based approach? Is that what most customers who are using ASA end up gravitating towards (just trying to orient myself since I'm not deeply familiar with the service)?
As I was reviewing this, I kept wanting to look at a sample application that uses this - did you happen to construct one as part of testing?
We have a few end to end samples that we like to run and in service of these we've built very simple applications that we can use to validate azd
without building out larger apps like our ToDo sample).
One example is this small dotnet app that runs on app service: https://github.com/Azure/azure-dev/tree/main/cli/azd/test/functional/testdata/samples/webapp
I'd love if we could get a similar version here for the spring app and build an integration test around it. That will be very helpful for our team.
hi @ellismg , let me answer your questions.
After talking with our PM, jar deployment is the most popular way for customers in ASA. I have submitted new commits to use jar deployment instead of container image. Please help to review again, thanks!
As you mentioned e2e samples, I create a spring integration test in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great overall. Added a few questions around how to leverage some of our best practices and dev standards when creating new service targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few minor comments but this looks great! Thanks for the contribution.
so much thanks for your comments @wbreza |
|
Pushed a new commit with the changes to make this |
cli/azd/test/functional/testdata/samples/springapp/infra-bicep/resources.bicep
Outdated
Show resolved
Hide resolved
I am trying to use this new host to deploy the todo-java-mongo template but I am getting this error during deployment: Please use this repo/PR/branch https://github.com/vhvb1989/springapps/pull/1 to test The repo has a copy of todo-java-mongo template and I created a branch with changes to use springapps instead of webapps. I was able to run Please take a look and see if that's an issue on azd or in the template... and help me understand how to fix this. |
@weikanglim What is your comment regarding |
I create a new PR for you https://github.com/vhvb1989/springapps/pull/2#pullrequestreview-1401792171, pls take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the todo-java template successfully.
I think this is good as it is for alpha
. I would like to see if we can break the dependency between the name for the service to be the same as the name for the spring-app.
For example, maybe if provision can output the name of the spring-app created inside the asa-instance, then azd could get the name from the environment. But that's future work/enhancement.
Thank you very much for your work and contribution here.
@weikanglim can you take care of clicking |
@vhvb1989 Is there a PR to incorporate an ASA template into |
ASA team is working on converting the following templates to be azd compatible and should be there for the May 9th release.
Can we get those added to our template test pipelines? |
/azp run azure dev - cli |
No pipelines are associated with this pull request. |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference (preview)
|
Matt's suggestion has been addressed. Additional follow-up needed for final integration tests to be added.
Add ASA support to AZD:
About the deployment - Azure Spring Apps support different ways to deploy apps:
This PR choose jar file to finish the app deployment.