-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet user-secrets
performance improvement
#2026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will want to update our sample .NET ToDo apps as part of this change to set this value to "true", otherwise we are going to break the F5 scenario.
Let's also remember to call out in the CHANGELOG that this is a breaking change and advise folks to add userSecrets: true
if they need the old behavior.
Reduced overall time by 2 minutes for dotnet-podcasts app. Before real 18m55.350s
user 0m19.059s
sys 0m7.099s After real 16m33.230s
user 0m17.459s
sys 0m4.999s |
dotnet user-secrets
performance improvement
@ellismg Please take a 2nd pass here. I was able to resolve this using updated support to set multiple secrets in a single call. |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference (preview)
|
Slick! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like support for setting multiple secrets was added in dotnet 6 and we already require that as a minimum version.
Resolves: #1695
Pipes in multiple values to
dotnet user-serets set
fromstdin
Resources